Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local test test_saving_remote fail #2707

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Mecoli1219
Copy link
Contributor

Tracking issue

flyteorg/flyte#5687

Why are the changes needed?

get_and_save_remote_with_click_context(...) will call get_remote(cfg_file_location, ...), which will call get_config_file if the first argument is None.
As described in #2705, get_config_file will not always return None in developers' local environments.

What changes were proposed in this pull request?

Add a mock function that forces the return value of get_config_file to None.

How was this patch tested?

make unit_test

Setup process

Run it locally

Screenshots

I'll open other PRs to fix the other 2 unit tests.
image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#2705
#2706

Docs link

Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
@pingsutw pingsutw merged commit a50eb4b into flyteorg:master Aug 23, 2024
98 of 99 checks passed
@Mecoli1219 Mecoli1219 deleted the fix_test_saving_remote branch August 24, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants