Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local test test_get_remote fail #2706

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Mecoli1219
Copy link
Contributor

@Mecoli1219 Mecoli1219 commented Aug 23, 2024

Tracking issue

flyteorg/flyte#5687

Why are the changes needed?

FlytekitPlugin.get_remote(None, ...) will call get_config_file if the first argument is None.
As described in #2705, get_config_file will not always return None in developers' local environments.

What changes were proposed in this pull request?

Add a mock function that forces the return value of get_config_file to None.

How was this patch tested?

make unit_test

Setup process

Run it locally

Screenshots

I'll open other PRs to fix the other 2 unit tests.
image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#2705
#2707

Docs link

Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.67%. Comparing base (a8f68d7) to head (319e637).
Report is 13 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a8f68d7) and HEAD (319e637). Click for more details.

HEAD has 17 uploads less than BASE
Flag BASE (a8f68d7) HEAD (319e637)
32 15
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2706       +/-   ##
===========================================
- Coverage   78.91%   48.67%   -30.25%     
===========================================
  Files         316      253       -63     
  Lines       24965    22401     -2564     
  Branches     4012     2773     -1239     
===========================================
- Hits        19702    10904     -8798     
- Misses       4548    11388     +6840     
+ Partials      715      109      -606     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 0f42872 into flyteorg:master Aug 23, 2024
99 of 101 checks passed
@Mecoli1219 Mecoli1219 deleted the fix_test_get_remote branch August 24, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants