Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an exception when filters' value isn't a list. #2576

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Raise an exception when filters' value isn't a list. #2576

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
94f30dc
Add an exeception when filters' value isn't a list
arbaobao Jul 10, 2024
81680f7
Merge branch 'flyteorg:master' into master
arbaobao Jul 10, 2024
36eb93d
Make the exception more specific
arbaobao Jul 18, 2024
d8d952f
add an unit test for value_in
arbaobao Aug 2, 2024
e00d78d
Merge branch 'flyteorg:master' into master
arbaobao Aug 3, 2024
e6bb844
lint
pingsutw Aug 3, 2024
4572e33
Merge branch 'master' of github.com:flyteorg/flytekit into arbaobao/m…
pingsutw Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flytekit/models/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,11 @@ def __init__(self, key, values):
:param Text key: The name of the field to compare against
:param list[Text] values: A list of textual values to compare.
"""
if not isinstance(values, list):
raise TypeError(f"values must be a list. but got {type(values)}")
super(SetFilter, self).__init__(key, ";".join(values))


@classmethod
def _parse_value(cls, value):
return value.split(";")
Expand Down
6 changes: 5 additions & 1 deletion tests/flytekit/unit/models/test_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from flytekit.models import filters

import pytest

def test_eq_filter():
assert filters.Equal("key", "value").to_flyte_idl() == "eq(key,value)"
Expand Down Expand Up @@ -28,6 +28,10 @@ def test_lte_filter():
def test_value_in_filter():
assert filters.ValueIn("key", ["1", "2", "3"]).to_flyte_idl() == "value_in(key,1;2;3)"

def test_invalid_value_in_filter():
with pytest.raises(TypeError, match=r"values must be a list. but got .*"):
filters.ValueIn("key", "1")


def test_contains_filter():
assert filters.Contains("key", ["1", "2", "3"]).to_flyte_idl() == "contains(key,1;2;3)"
Expand Down
Loading