-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise an exception when filters' value isn't a list. #2576
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2576 +/- ##
==========================================
- Coverage 78.77% 76.19% -2.58%
==========================================
Files 187 187
Lines 19149 19151 +2
Branches 3993 3994 +1
==========================================
- Hits 15085 14593 -492
- Misses 3374 3899 +525
+ Partials 690 659 -31 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nelson Chen <asd3431090@gmail.com>
Can you add a unit test? |
Signed-off-by: Nelson Chen <asd3431090@gmail.com>
@arbaobao This is not signed off yet. You can find instructions on how to sign off here: https://github.com/flyteorg/flytekit/pull/2576/checks?check_run_id=28277359939 |
@arbaobao there is a linting error, could you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Congrats on merging your first pull request! 🎉 |
* Add an exeception when filters' value isn't a list * Make the exception more specific Signed-off-by: Nelson Chen <asd3431090@gmail.com> * add an unit test for value_in Signed-off-by: Nelson Chen <asd3431090@gmail.com> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Nelson Chen <asd3431090@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org>
* Add an exeception when filters' value isn't a list * Make the exception more specific Signed-off-by: Nelson Chen <asd3431090@gmail.com> * add an unit test for value_in Signed-off-by: Nelson Chen <asd3431090@gmail.com> * lint Signed-off-by: Kevin Su <pingsutw@apache.org> --------- Signed-off-by: Nelson Chen <asd3431090@gmail.com> Signed-off-by: Kevin Su <pingsutw@apache.org> Co-authored-by: Kevin Su <pingsutw@apache.org> Signed-off-by: mao3267 <chenvincent610@gmail.com>
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link