Repository navigation
Fix Wesley core and emitter syntax-model boundaries - #613
Merged
Merged
Conversation
|
Warning Review limit reached
More reviews will be available in 1 minute and 37 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRemoves host-issued authority structs ( ChangesCore Boundary Cleanup and TS Emitter Refactor
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 The Case of Pull Request #613Plain-English Readout
Suggested next actions
📚 Glossary (what the Holmes terms mean)
🕵️ SHA-lock HOLMES full report (click to expand)🕵️ SHA-lock HOLMES Investigation
🔍 Executive Deduction"Watson, after careful examination of the evidence, I deduce..." Weighted Completion: ██████████ 95.0% 🧩 SCS Breakdown
🧪 TCI Breakdown
|
| Component | Risk Share | Points | Count |
|---|---|---|---|
| Drops | 0.0% | 0 | 0 |
| Renames Without Uid | 0.0% | 0 | 0 |
| Add Not Null Without Default | 100.0% | 1 | 1 |
| Non Concurrent Indexes | 0.0% | 0 | 0 |
📊 The Weight of Evidence
"Observe, Watson, how not all features carry equal importance..."
| Element | Weight | Status | Evidence | Strength | Deduction |
|---|---|---|---|---|---|
| schema | 5 | ✅ Exact SQL & tests | test/fixtures/examples/.wesley-cache/shipme-fixture/tests.sql:1-1@a3bfad0 | exact | Elementary! |
🚪 Security & Performance Gates
"Elementary security measures, Watson..."
| Gate | Status | Evidence | Holmes's Ruling |
|---|---|---|---|
| Migration Risk | ✅ | MRI: 10.0% | "Trivial risk" |
| Test Coverage | ✅ | TCI: 90.0% | "Excellent coverage" |
| Sensitive Fields | ✅ | 0 fields | "All secured" |
| Evidence Quality | ✅ | 2 exact · 0 whole-file · 0 coarse | "All 2 citations resolve to exact line spans." |
📋 The Verdict
✅ ELEMENTARY - Ship immediately!
"The evidence is conclusive. No mysteries remain."
Signed and sealed,
- S. Holmes, Consulting Detective
[END OF INVESTIGATION FOR COMMIT a3bfad0]
🧵 Command Run
- Run ID: run-c18268ba-d4e2-4574-b900-ad283a3ec5c2
- Transmutation: holmes-investigate
- Command: investigate
- Status: completed
- Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger
🩺 Dr. WATSON full report (click to expand)
🩺 Dr. Watson's Independent Verification Report
Medical Examination of Evidence
- Examination Date: 2026-06-19T19:00:11.597Z
- Patient SHA: a3bfad0
🔬 Citation Verification
"Let me examine each piece of evidence independently..."
- Citations Examined: 2
- Verified: 0 ✅
- Failed: 0 ❌
- Unable to Verify: 2
- Exact Subrange Citations: 0
- Whole-file Citations: 0
- Coarse Citations: 0
- Evidence Trust: missing
- Trust Note: No evidence citations were available for trust analysis.
Verification Rate: 0.0%
📊 Mathematical Verification
"I shall recalculate Holmes's arithmetic..."
Holmes claimed SCS: 95.0%
Watson calculates: 100.0%
Difference:
🔍 Consistency Analysis
"Checking for contradictions in Holmes's deductions..."
✅ No logical inconsistencies detected
🩺 Dr. Watson's Medical Opinion
VERIFICATION: CONCERNS NOTED
"While Holmes's methods are generally sound, I have noted some"
"discrepancies that warrant further investigation. No evidence citations were available for trust analysis."
Respectfully submitted,
- Dr. J. Watson, M.D.
Medical Examiner & Verification Specialist
🧵 Command Run
- Run ID: run-c7880544-0680-4858-bdc3-20bad7909812
- Transmutation: watson-verify
- Command: verify
- Status: completed
- Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger
🔮 Professor MORIARTY full report (click to expand)
🧠 Professor Moriarty's Temporal Predictions
The Mathematics of Inevitability
- Analysis Date: 2026-06-19T19:00:43.242Z
INSUFFICIENT DATA
"I require at least two data points to predict the future."
"Run Wesley generate multiple times to build history."
🧵 Command Run
- Run ID: run-b38b3cea-0627-4a27-8118-d8bb9b73e11f
- Transmutation: moriarty-predict
- Command: predict
- Status: completed
- Ledger: /home/runner/work/wesley/wesley/test/fixtures/examples/.wesley-cache/ledger
Machine-readable reports: holmes-report.json · watson-report.json · moriarty-report.json (see workflow artifacts).
Filed at 221B Repository Street
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
Owner
Author
Self-Code ReviewCc: @codex for second opinion.
No P0/P1 issues found in this pass. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40a68130bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
Activity Summary
Self-audit found no additional unresolved defects beyond the PR review queue. Validation:
|
Owner
Author
Code Lawyer Self-ReviewCc: @codex for confirmation. Review basis: clean local worktree before review,
No P0 issues found. I do not consider the existing markdownlint baseline in Merge-readiness note: GitHub currently reports this PR as |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d384d0a88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
@codex Activity summary after resolving the strict self-review findings:
Local validation passed:
The self-review threads for the P1/P3 findings have been resolved. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/wesley-emit-typescript/src/le_binary.rs`:
- Around line 1135-1147: The assert_no_runtime_operation_markers function
currently only checks for one specific constant (OP_MAKE_WIDGET) by joining
those exact strings, which allows other OP-style constants to slip through.
Instead of checking for the exact constant formed by joining ["OP", "MAKE",
"WIDGET"], broaden the pattern check to detect any OP-prefixed constant (for
example, by checking for the presence of "OP_" in the TypeScript string). This
ensures that any unexpected OP constant, regardless of what follows the OP_
prefix, will be caught as a regression.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 94174c6b-0fc1-4b87-b3dc-9d9af4bfa7f3
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (18)
CHANGELOG.mdREADME.mdcrates/wesley-core/src/adapters/apollo.rscrates/wesley-core/src/domain/operation.rscrates/wesley-core/src/domain/optic.rscrates/wesley-core/tests/operation_analysis.rscrates/wesley-core/tests/runtime_optic_artifact.rscrates/wesley-emit-rust/README.mdcrates/wesley-emit-typescript/README.mdcrates/wesley-emit-typescript/src/le_binary.rsdocs/JEDIT_CAPABILITY_PROGRESS.mddocs/NORTHSTAR.mddocs/SDL.mddocs/TECHNICAL_TEARDOWN.mdpackage.jsontest/domain-empty-boundary.batstest/fixtures/typescript-emitter/le-binary-codec.generated.tstest/fixtures/typescript-emitter/le-binary-codec.graphql
💤 Files with no reviewable changes (1)
- crates/wesley-core/src/domain/operation.rs
Summary
Testing
|
Owner
Author
|
@codex Phase III Activity Summary
Validation run for the final head:
Review-thread state after push: 5 total, 5 resolved. CodeRabbit currently reports pass; GitHub Actions are pending after the new commit. |
Summary
Testing
|
🚢 SHIPME[SHIPME] PASS · HOLMES fixture · sha a3bfad0 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/ci-workflows.bats`:
- Around line 18-26: The sed command in all three bash invocations uses the
range pattern `/^ bun-smoke:/,$p` which extracts from the bun-smoke job
definition all the way to the end of the file. This causes the assertions to
potentially match content from jobs that appear after bun-smoke, making the
tests brittle. Modify the sed range in all three run commands to terminate at
the end of the bun-smoke job block instead of EOF, by changing the range end
pattern from `$` to a pattern that matches the next job definition (such as
`/^[^ ]/ for a line starting at column 1, or use a more specific pattern that
captures the end of the bun-smoke stanza).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d8f39afe-c154-47c1-a362-f270fc49536b
📒 Files selected for processing (3)
.github/workflows/runtime-smokes.ymlcrates/wesley-emit-typescript/src/le_binary.rstest/ci-workflows.bats
🚧 Files skipped from review as they are similar to previous changes (1)
- crates/wesley-emit-typescript/src/le_binary.rs
Owner
Author
|
@codex Self-Code Review pass for PR #613.
Validation during review:
Notes:
|
Owner
Author
|
@codex Activity Summary: resolved the self-discovered workflow guard issue from the strict review pass.
Current state: branch pushed at |
Summary
Testing
|
|
Summary
Testing
|
Owner
Author
|
@codex Self-audit round 2 found one still-actionable issue before merge.
I will resolve this with a focused regression and one commit. |
Owner
Author
|
@codex Activity Summary: resolved self-audit round 2.
Console SitRep:
|
Summary
Testing
|
Summary
Testing
|
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wesley-coreand stop exporting runtimeOP_*constants from the generic LE binary TypeScript emitter.Why
Wesley core should stay domain-empty and runtime-neutral. Target-owned extensions should supply runtime operation identifiers and authority vocabulary instead of inheriting them from generic Wesley core.
The emitter side now matches the same discipline: TypeScript and Rust generation use syntax-model-to-printer pipelines, avoiding semantic lowering code that assembles source text directly.
Validation
bats -t test/domain-empty-boundary.batscargo test -p wesley-core -p wesley-emit-typescriptcargo test -p wesley-emit-rustcargo clippy -p wesley-emit-typescript --all-targets -- -D warningspnpm run preflightcargo xtask preflightNotes
This PR intentionally does not introduce runtime target-specific operation IDs into Wesley core. Echo, git-warp, or other target profiles should own those identifiers in their target-specific extension layer.
Summary by CodeRabbit
undiciversion override to eliminate audit/CI jsdom advisories.