Repository navigation
feat(echo): wire trusted runtime lifecycle into jedit - #27
Merged
Merged
Conversation
|
Warning Review limit reached
Your plan currently allows 1 review/hour. Refill in 55 minutes and 31 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (57)
WalkthroughAdds a full release-gate: trusted Echo lifecycle port and adapter, installed-contract transport and package installer/preflight, jedit mutation handlers and query observers, in-memory hosting boundaries (ledger/state/ticketing/retention), echo-powered TextBufferOptic session and witness orchestration, CLI witness and release-gate scripts, extensive tests, and documentation and release artifacts. ChangesRelease Gate: Lifecycle, Contracts, Transport, Witnesses
Sequence Diagram(s)sequenceDiagram
participant Client as EchoPoweredTextBufferOpticSession
participant Lifecycle as TrustedEchoRuntimeLifecyclePort
participant Host as EchoWasmKernelHostTransport
Client->>Host: submitIntentBytes(intent)
Client->>Lifecycle: requestRunUntilIdle(cycleLimit)
Lifecycle->>Host: dispatchControlIntentBytes(run-until-idle)
Host-->>Lifecycle: EchoRunUntilIdleResult
Host-->>Client: observeBytes(readingEnvelope)
Client-->>Lifecycle: requestStop()
Lifecycle->>Host: dispatchControlIntentBytes(stop)
Host-->>Lifecycle: EchoStopResult
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
|
Owner
Author
|
@codex spot check please: this PR wires jedit trusted Echo lifecycle control into the product-session path. Please focus on whether the authority split stays intact: app-facing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f88070720
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
@codex Boundary update pushed in
Companion Echo PR: flyingrobots/echo#377 removes the actual hardcoded Stack Witness text fixture from Validation: |
|
To use Codex here, create an environment for this repo. |
Owner
Author
|
@codex PR #27 review backlog pass completed.
False-positive / stale reviewer note handled: the quickstart comment claiming the shipped witness uses Final local gate on pushed head |
|
To use Codex here, create an environment for this repo. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This was referenced Jun 3, 2026
This was referenced Jun 25, 2026
This was referenced Jul 3, 2026
Closed
This was referenced Jul 13, 2026
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR wires jedit's Echo lifecycle authority into the product-side integration path without letting application code tick Echo.
It adds five focused slices:
TextBufferOpticsession composition that requests lifecycle after mutations only.Stopsupport through the same host-only port.Authority boundaries
TextBufferOptic, not Echo control exports.requestRunUntilIdleandrequestStopremain trusted-host-only.Verification
npm run checknpm run witness:echo:sessionnpm run checkpassed locally with 279 passing tests, 1 opt-in real Echo WASM witness skipped, and quality clean.