Skip to content

Don't fail to boot if can't sync config from consul #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Don't fail to boot if can't sync config from consul #132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
468c2c9
Don't fail to boot if can't sync config from consul
Feb 23, 2023
ac5894f
Don't overrite on failure
Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions internal/flypg/pg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,15 @@ func (c *PGConfig) initialize(store *state.Store) error {
}

if err := SyncUserConfig(c, store); err != nil {
return fmt.Errorf("failed to sync user config from consul for postgres: %s", err.Error())
}

if err := WriteConfigFiles(c); err != nil {
return fmt.Errorf("failed to write pg config files: %s", err)
fmt.Printf("WARNING: Failed to sync user config from consul for postgres: %s\n", err.Error())
fmt.Println(" This may cause this node to behave unexpectedly")
if err := writeInternalConfigFile(c); err != nil {
return fmt.Errorf("failed to write pg config files: %s", err)
}
} else {
if err := WriteConfigFiles(c); err != nil {
return fmt.Errorf("failed to write pg config files: %s", err)
}
}

return nil
Expand Down