Skip to content

Don't fail to boot if can't sync config from consul #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2023
Merged

Don't fail to boot if can't sync config from consul #132

merged 2 commits into from
Feb 24, 2023

Conversation

@DAlperin
Copy link
Contributor

@DAlperin DAlperin commented Feb 23, 2023

No description provided.

@DAlperin DAlperin marked this pull request as ready for review February 23, 2023 21:30
davissp14
davissp14 requested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@davissp14 davissp14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this fails, we should make sure that we don't write to the user config file.

davissp14
davissp14 approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@davissp14 davissp14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davissp14 davissp14 merged commit 5ab821c into master Feb 24, 2023
@davissp14 davissp14 mentioned this pull request Feb 24, 2023
Closed
@davissp14 davissp14 deleted the dont_fail_boot_config branch February 25, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davissp14 davissp14 davissp14 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DAlperin @davissp14