Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-blob: Fix VisitObjects() in integration test #1574

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

darkowlzz
Copy link
Contributor

While reviewing #1567, I noticed that the integration tests file had errors since the bucket prefix filtering was introduced in #1228. Because we have disabled azure tests due to lack of an account, that file with integration build tag never gets executed in the CI. I believe even the IDEs don't detect it unless go build flag -tags=integration is set.

Signed-off-by: Sunny <github@darkowlzz.space>
@darkowlzz darkowlzz added the area/testing Testing related issues and pull requests label Aug 9, 2024
@darkowlzz darkowlzz merged commit f494cf8 into main Aug 9, 2024
10 checks passed
@darkowlzz darkowlzz deleted the az-blob-int-visitobjects branch August 9, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants