Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy support for Azure buckets #1567

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Add proxy support for Azure buckets #1567

merged 1 commit into from
Aug 11, 2024

Conversation

matheuscscp
Copy link
Collaborator

@matheuscscp matheuscscp commented Aug 5, 2024

Part of #1563

I was able to manually test this using a Blob SAS Token in my personal Azure account.

api/v1beta2/bucket_types.go Outdated Show resolved Hide resolved
docs/spec/v1beta2/buckets.md Outdated Show resolved Hide resolved
@matheuscscp matheuscscp marked this pull request as ready for review August 5, 2024 12:20
@stefanprodan stefanprodan added the area/bucket Bucket related issues and pull requests label Aug 5, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🏅

Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks.

@matheuscscp
Copy link
Collaborator Author

I'm trying an attempt to test at least the proxy integration with a mock server here, will update the PR with the results.

Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proxy test.
LGTM!

@matheuscscp matheuscscp merged commit 08fff65 into main Aug 11, 2024
9 checks passed
@matheuscscp matheuscscp deleted the bucket-azure-proxy branch August 11, 2024 20:34
@stefanprodan stefanprodan added this to the Bucket GA milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bucket Bucket related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants