Refactor garbage collection #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
gc-prune
branch
from
28cb02a
to
59845b0
Compare
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
gc-prune
branch
from
91d17ce
to
88b6d40
Compare
hiddeco
reviewed
Dec 16, 2020
| func (kgc *KustomizeGarbageCollector) matchingLabels(name, namespace, checksum string) client.MatchingLabels { | ||
| return gcLabels(name, namespace, checksum) | ||
| func (kgc *KustomizeGarbageCollector) isStale(obj unstructured.Unstructured) bool { | ||
| itemChecksum := obj.GetLabels()[fmt.Sprintf("%s/checksum", kustomizev1.GroupVersion.Group)] |
There was a problem hiding this comment.
I would move the fmt.Sprintf to a dedicated function as it is also used in the gcLabels function, or move the various label names to constants, and create something like:
const gcNameLabel = "name"
func gcLabelName(name string) string {
return fmt.Sprintf("%s/%s", kustomizev1.GroupVersion.Group, name)
}Avoid v0.6.4 bug where custom resources can't be converted to v1.ListOptions Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
hiddeco
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete stale objects if their checksum doesn't match the last applied revision. This accounts for controller restarts during reconciliation, previously, if GC was killed while running, stale objects would never be removed.
Pin controller-runtime to v0.6.3 (mitigation until we upgrade to v0.7.0), ref: #214, fix: #209