Add documentation on the AndroidX migration #2349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
sfshaza2
approved these changes
Feb 7, 2019
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
There are a few minor changes I'd made, as a writer, but nothing significant. LGTM
jamesderlin
reviewed
Feb 7, 2019
| use both sets of libraries. | ||
|
|
||
| Some Flutter plugins have been migrated to AndroidX after originally using the | ||
| original suport libraries. Flutter apps that aren't compatible with AndroidX |
| This requires the latest version of Android Studio. | ||
|
|
||
| 1. Follow the instructions on [this | ||
| page](https://flutter.io/docs/development/tools/android-studio#android-ide) |
Contributor
There was a problem hiding this comment.
There are a number of "this page" links. We should strongly prefer descriptive links (e.g. "Follow the instructions to import a Flutter app into Android Studio", "Follow the instructions for migrating an app to AndroidX automatically using Android Studio").
One major problem with "This page" (or "here") links is that they're terrible for things that scrape links from a page (such as screen readers) since they'll end up with a bunch of links that all look the same.
Contributor
Author
|
@jamesderlin I opened a follow up PR at #2360. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.