Skip to content

Conversation

@mklim
Copy link
Contributor

@mklim mklim commented Feb 7, 2019

No description provided.

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Feb 7, 2019
@mklim mklim requested a review from sfshaza2 February 7, 2019 21:38
@mklim
Copy link
Contributor Author

mklim commented Feb 7, 2019

Added a second commit with changes following review from @jamesderlin.

@mklim mklim requested a review from jamesderlin February 7, 2019 22:10
@mklim mklim changed the title Fix closing tag on AndroidX page Fix up AndroidX page Feb 7, 2019
Copy link
Contributor

@jamesderlin jamesderlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better. Thanks!

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2 sfshaza2 merged commit c50a80c into flutter:master Feb 7, 2019
@mklim mklim deleted the androidx_info_fix branch February 7, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants