Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Support sign-in with Github and linking Github accounts to existing users #768

Merged
merged 6 commits into from
Nov 8, 2018

Conversation

filleduchaos
Copy link
Contributor

Fulfills feature request: flutter/flutter#21331

@bparrishMines bparrishMines force-pushed the feat/add-github branch 4 times, most recently from 471f18a to e3449db Compare November 8, 2018 01:14
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Thanks for contributing!

@bparrishMines bparrishMines changed the title Support sign-in with Github and linking Github/Twitter accounts to existing users Support sign-in with Github and linking Github accounts to existing users Nov 8, 2018
@bparrishMines bparrishMines merged commit d7bd97f into flutter:master Nov 8, 2018
@lukepighetti
Copy link

@filleduchaos Hello, how is this intended to be used? Where do we get the Token from?

@filleduchaos
Copy link
Contributor Author

@lukepighetti Hey sorry - saw this late! Much like with any OAuth thing you'd get the token back from the provider (in this case, likely through a Sign In With Github web flow)

andreidiaconu pushed a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
andreidiaconu added a commit to andreidiaconu/plugins that referenced this pull request Feb 17, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants