Merge branch 'master' of github.com:flutter/plugins into feat/add-github

Author: bparrishMines

.cirrus.yml

@@ -33,7 +33,7 @@ task:
 task:
   name: build-ipas
   osx_instance:
-    image: high-sierra-xcode-9.4
+    image: high-sierra-xcode-9.4.1
   env:
     PATH: $PATH:/usr/local/bin
     matrix:

.opensource/project.json

@@ -5,19 +5,19 @@
     "iOS"
   ],
   "content": "FlutterFire.md",
-  "pages": [
-    "packages/cloud_firestore/README.md",
-    "packages/cloud_functions/README.md",
-    "packages/firebase_admob/README.md",
-    "packages/firebase_analytics/README.md",
-    "packages/firebase_auth/README.md",
-    "packages/firebase_core/README.md",
-    "packages/firebase_database/README.md",
-    "packages/firebase_dynamic_links/README.md",
-    "packages/firebase_messaging/README.md",
-    "packages/firebase_ml_vision/README.md",
-    "packages/firebase_performance/README.md",
-    "packages/firebase_remote_config/README.md",
-    "packages/firebase_storage/README.md"
-  ]
-}
+  "pages": {
+    "packages/cloud_firestore/README.md": "Cloud Firestore",
+    "packages/cloud_functions/README.md": "Cloud Functions",
+    "packages/firebase_admob/README.md": "Admob",
+    "packages/firebase_analytics/README.md": "Analytics",
+    "packages/firebase_auth/README.md": "Authentication",
+    "packages/firebase_core/README.md": "Core",
+    "packages/firebase_database/README.md": "Realtime Database",
+    "packages/firebase_dynamic_links/README.md": "Dynamic Links",
+    "packages/firebase_messaging/README.md": "Cloud Messaging",
+    "packages/firebase_ml_vision/README.md": "ML Kit: Vision",
+    "packages/firebase_performance/README.md": "Performance Monitoring",
+    "packages/firebase_remote_config/README.md": "Remote Config",
+    "packages/firebase_storage/README.md": "Cloud Storage"
+  }
+}

analysis_options.yaml

@@ -112,6 +112,7 @@ linter:
     # - prefer_interpolation_to_compose_strings # not yet tested
     - prefer_is_empty
     - prefer_is_not_empty
+    - prefer_void_to_null
     # - recursive_getters # https://github.com/dart-lang/linter/issues/452
     - slash_for_doc_comments
     - sort_constructors_first
@@ -124,6 +125,7 @@ linter:
     - unnecessary_const
     - unnecessary_getters_setters
     # - unnecessary_lambdas # https://github.com/dart-lang/linter/issues/498
+    - unnecessary_new
     - unnecessary_null_aware_assignments
     - unnecessary_null_in_if_null_operators
     # - unnecessary_overrides # https://github.com/dart-lang/linter/issues/626 and https://github.com/dart-lang/linter/issues/627

packages/android_alarm_manager/README.md

@@ -22,7 +22,7 @@ Then in Dart code add:
 import 'package:android_alarm_manager/android_alarm_manager.dart';
 
 void printHello() {
-  final DateTime now = new DateTime.now();
+  final DateTime now = DateTime.now();
   final int isolateId = Isolate.current.hashCode;
   print("[$now] Hello, world! isolate=${isolateId} function='$printHello'");
 }

packages/android_alarm_manager/example/android/gradle/wrapper/gradle-wrapper.properties

@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.10-all.zip

packages/android_alarm_manager/example/lib/main.dart

@@ -12,7 +12,7 @@ import 'package:flutter/widgets.dart';
 final FirebaseAuth firebaseAuth = FirebaseAuth.instance;
 FirebaseUser firebaseUser;
 
-Future<Null> ensureFirebaseUser() async {
+Future<void> ensureFirebaseUser() async {
   if (firebaseUser == null) {
     firebaseUser = await firebaseAuth.currentUser();
     if (firebaseUser == null) {
@@ -22,14 +22,14 @@ Future<Null> ensureFirebaseUser() async {
 }
 
 class HelloMessage {
+  HelloMessage(this._now, this._msg, this._isolate, this._user, this._token);
+
   final DateTime _now;
   final String _msg;
   final int _isolate;
   final FirebaseUser _user;
   final String _token;
 
-  HelloMessage(this._now, this._msg, this._isolate, this._user, this._token);
-
   @override
   String toString() {
     return "[$_now] $_msg "
@@ -42,8 +42,8 @@ class HelloMessage {
 void printHelloMessage(String msg) {
   ensureFirebaseUser().then((_) {
     firebaseUser.getIdToken().then((String idToken) {
-      print(new HelloMessage(
-        new DateTime.now(),
+      print(HelloMessage(
+        DateTime.now(),
         msg,
         Isolate.current.hashCode,
         firebaseUser,
@@ -67,7 +67,7 @@ void printOneShot() {
   printHelloMessage("Hello, once!");
 }
 
-Future<Null> main() async {
+Future<void> main() async {
   final int helloAlarmID = 0;
   final int goodbyeAlarmID = 1;
   final int oneShotID = 2;

packages/android_alarm_manager/lib/android_alarm_manager.dart

@@ -28,7 +28,7 @@ void _alarmManagerCallbackDispatcher() {
   // native portion of the plugin.
   _channel.setMethodCallHandler((MethodCall call) async {
     final dynamic args = call.arguments;
-    final CallbackHandle handle = new CallbackHandle.fromRawHandle(args[0]);
+    final CallbackHandle handle = CallbackHandle.fromRawHandle(args[0]);
 
     // PluginUtilities.getCallbackFromHandle performs a lookup based on the
     // callback handle and returns a tear-off of the original callback.
@@ -100,7 +100,7 @@ class AndroidAlarmManager {
     bool exact = false,
     bool wakeup = false,
   }) async {
-    final int now = new DateTime.now().millisecondsSinceEpoch;
+    final int now = DateTime.now().millisecondsSinceEpoch;
     final int first = now + delay.inMilliseconds;
     final CallbackHandle handle = PluginUtilities.getCallbackHandle(callback);
     if (handle == null) {
@@ -145,7 +145,7 @@ class AndroidAlarmManager {
     bool exact = false,
     bool wakeup = false,
   }) async {
-    final int now = new DateTime.now().millisecondsSinceEpoch;
+    final int now = DateTime.now().millisecondsSinceEpoch;
     final int period = duration.inMilliseconds;
     final int first = now + period;
     final CallbackHandle handle = PluginUtilities.getCallbackHandle(callback);

packages/android_intent/README.md

@@ -7,9 +7,9 @@ mode, we assert that the platform should be Android.
 Use it by specifying action, category, data and extra arguments for the intent.
 It does not support returning the result of the launched activity. Sample usage:
 
-```
+```dart
 if (platform.isAndroid) {
-  AndroidIntent intent = new AndroidIntent(
+  AndroidIntent intent = AndroidIntent(
       action: 'action_view',
       data: 'https://play.google.com/store/apps/details?'
           'id=com.google.android.apps.myapp',

packages/android_intent/example/android/gradle/wrapper/gradle-wrapper.properties

@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.10-all.zip

packages/android_intent/example/lib/main.dart

@@ -7,19 +7,19 @@ import 'package:flutter/material.dart';
 import 'package:platform/platform.dart';
 
 void main() {
-  runApp(new MyApp());
+  runApp(MyApp());
 }
 
 class MyApp extends StatelessWidget {
   // This widget is the root of your application.
   @override
   Widget build(BuildContext context) {
-    return new MaterialApp(
+    return MaterialApp(
       title: 'Flutter Demo',
-      theme: new ThemeData(
+      theme: ThemeData(
         primarySwatch: Colors.blue,
       ),
-      home: new MyHomePage(),
+      home: MyHomePage(),
       routes: <String, WidgetBuilder>{
         ExplicitIntentsWidget.routeName: (BuildContext context) =>
             const ExplicitIntentsWidget()
@@ -51,17 +51,17 @@ class MyHomePage extends StatelessWidget {
   Widget build(BuildContext context) {
     Widget body;
     if (const LocalPlatform().isAndroid) {
-      body = new Padding(
+      body = Padding(
         padding: const EdgeInsets.symmetric(vertical: 15.0),
-        child: new Column(
+        child: Column(
           mainAxisAlignment: MainAxisAlignment.spaceEvenly,
           children: <Widget>[
-            new RaisedButton(
+            RaisedButton(
               child: const Text(
                   'Tap here to set an alarm\non weekdays at 9:30pm.'),
               onPressed: _createAlarm,
             ),
-            new RaisedButton(
+            RaisedButton(
                 child: const Text('Tap here to test explicit intents.'),
                 onPressed: () => _openExplicitIntentsView(context)),
           ],
@@ -70,38 +70,38 @@ class MyHomePage extends StatelessWidget {
     } else {
       body = const Text('This plugin only works with Android');
     }
-    return new Scaffold(
-      appBar: new AppBar(
+    return Scaffold(
+      appBar: AppBar(
         title: const Text('Plugin example app'),
       ),
-      body: new Center(child: body),
+      body: Center(child: body),
     );
   }
 }
 
 class ExplicitIntentsWidget extends StatelessWidget {
-  static const String routeName = "/explicitIntents";
-
   const ExplicitIntentsWidget();
 
+  static const String routeName = "/explicitIntents";
+
   void _openGoogleMapsStreetView() {
-    final AndroidIntent intent = new AndroidIntent(
+    final AndroidIntent intent = AndroidIntent(
         action: 'action_view',
         data: Uri.encodeFull('google.streetview:cbll=46.414382,10.013988'),
         package: 'com.google.android.apps.maps');
     intent.launch();
   }
 
   void _displayMapInGoogleMaps({int zoomLevel = 12}) {
-    final AndroidIntent intent = new AndroidIntent(
+    final AndroidIntent intent = AndroidIntent(
         action: 'action_view',
         data: Uri.encodeFull('geo:37.7749,-122.4194?z=$zoomLevel'),
         package: 'com.google.android.apps.maps');
     intent.launch();
   }
 
   void _launchTurnByTurnNavigationInGoogleMaps() {
-    final AndroidIntent intent = new AndroidIntent(
+    final AndroidIntent intent = AndroidIntent(
         action: 'action_view',
         data: Uri.encodeFull(
             'google.navigation:q=Taronga+Zoo,+Sydney+Australia&avoid=tf'),
@@ -110,15 +110,15 @@ class ExplicitIntentsWidget extends StatelessWidget {
   }
 
   void _openLinkInGoogleChrome() {
-    final AndroidIntent intent = new AndroidIntent(
+    final AndroidIntent intent = AndroidIntent(
         action: 'action_view',
         data: Uri.encodeFull('https://flutter.io'),
         package: 'com.android.chrome');
     intent.launch();
   }
 
   void _testExplicitIntentFallback() {
-    final AndroidIntent intent = new AndroidIntent(
+    final AndroidIntent intent = AndroidIntent(
         action: 'action_view',
         data: Uri.encodeFull('https://flutter.io'),
         package: 'com.android.chrome.implicit.fallback');
@@ -127,35 +127,35 @@ class ExplicitIntentsWidget extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return new Scaffold(
-      appBar: new AppBar(
+    return Scaffold(
+      appBar: AppBar(
         title: const Text('Test explicit intents'),
       ),
-      body: new Center(
-        child: new Padding(
+      body: Center(
+        child: Padding(
           padding: const EdgeInsets.symmetric(vertical: 15.0),
-          child: new Column(
+          child: Column(
             mainAxisAlignment: MainAxisAlignment.spaceEvenly,
             children: <Widget>[
-              new RaisedButton(
+              RaisedButton(
                 child: const Text(
                     'Tap here to display panorama\nimagery in Google Street View.'),
                 onPressed: _openGoogleMapsStreetView,
               ),
-              new RaisedButton(
+              RaisedButton(
                 child: const Text('Tap here to display\na map in Google Maps.'),
                 onPressed: _displayMapInGoogleMaps,
               ),
-              new RaisedButton(
+              RaisedButton(
                 child: const Text(
                     'Tap here to launch turn-by-turn\nnavigation in Google Maps.'),
                 onPressed: _launchTurnByTurnNavigationInGoogleMaps,
               ),
-              new RaisedButton(
+              RaisedButton(
                 child: const Text('Tap here to open link in Google Chrome.'),
                 onPressed: _openLinkInGoogleChrome,
               ),
-              new RaisedButton(
+              RaisedButton(
                 child: const Text(
                     'Tap here to test explicit intent fallback to implicit.'),
                 onPressed: _testExplicitIntentFallback,

packages/android_intent/lib/android_intent.dart

@@ -12,14 +12,6 @@ const String kChannelName = 'plugins.flutter.io/android_intent';
 
 /// Flutter plugin for launching arbitrary Android Intents.
 class AndroidIntent {
-  final String action;
-  final String category;
-  final String data;
-  final Map<String, dynamic> arguments;
-  final String package;
-  final MethodChannel _channel;
-  final Platform _platform;
-
   /// Builds an Android intent with the following parameters
   /// [action] refers to the action parameter of the intent.
   /// [category] refers to the category of the intent, can be null.
@@ -38,11 +30,19 @@ class AndroidIntent {
         _channel = const MethodChannel(kChannelName),
         _platform = platform ?? const LocalPlatform();
 
+  final String action;
+  final String category;
+  final String data;
+  final Map<String, dynamic> arguments;
+  final String package;
+  final MethodChannel _channel;
+  final Platform _platform;
+
   /// Launch the intent.
   ///
   /// This works only on Android platforms. Please guard the call so that your
   /// iOS app does not crash. Checked mode will throw an assert exception.
-  Future<Null> launch() async {
+  Future<void> launch() async {
     assert(_platform.isAndroid);
     final Map<String, dynamic> args = <String, dynamic>{'action': action};
     if (category != null) {

packages/battery/README.md

@@ -14,7 +14,7 @@ To use this plugin, add `battery` as a [dependency in your pubspec.yaml file](ht
 import 'package:battery/battery.dart';
 
 // Instantiate it
-var battery = new Battery();
+var battery = Battery();
 
 // Access current battery level
 print(battery.batteryLevel);

packages/battery/example/android/gradle/wrapper/gradle-wrapper.properties

@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.10-all.zip