This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[file_selector] Migrate FileSelectorApi to Dart #6546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
11 tasks
adpinola
force-pushed
the
file_selector/windows/66584-migrate-FileSelectorApi
branch
2 times, most recently
from
f24e590 to
087006a
Compare
eugerossetto
force-pushed
the
file_selector/windows/66584-migrate-FileSelectorApi
branch
from
087006a to
39158c0
Compare
11 tasks
adpinola
force-pushed
the
file_selector/windows/66584-migrate-FileSelectorApi
branch
4 times, most recently
from
9a1ca9a to
07f6dce
Compare
11 tasks
adpinola
force-pushed
the
file_selector/windows/66584-migrate-FileSelectorApi
branch
from
07f6dce to
2d67630
Compare
Add methods of FileDialogController Add FileDialogController tests. Change the location where the free of the pointer is placed.
Add methods of FileDialogController Add FileDialogController tests. Extract the interface conversion to a new class to make it testable. Add DialogWrapper constructor. Add test constructor to DialogWrapper and add two tests. Add mock for FileDialogController and tests for implemented methods. free memory allocations remove unused properties in dialog_wrapper use Arena Return the value of the path. fix extension string list to remove trailing semicolon
add test suite for file_selector_api
adpinola
force-pushed
the
file_selector/windows/66584-migrate-FileSelectorApi
branch
from
2d67630 to
e8f9bd3
Compare
adpinola
deleted the
file_selector/windows/66584-migrate-FileSelectorApi
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes in #6518 and in #6539.
Issue: [file_selector_windows] Migrate CPP implementation to Dart. #112212
This exposes a new
FileSelectorApithat will replace the one generated bypigeon.This will be integrated with the next PR.
Things we have done:
FileSelectorApiSelectionOptionsclassDialogWrapperFactoryfor testabilityPre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.