This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[file_selector] Migrate DialogWrapper to Dart. #6539
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2022
adpinola
force-pushed
the
112212-migrate-dialog-wrapper-to-dart
branch
from
c32ee30 to
8f56715
Compare
11 tasks
adpinola
force-pushed
the
112212-migrate-dialog-wrapper-to-dart
branch
4 times, most recently
from
f0ae6cc to
156746a
Compare
11 tasks
adpinola
force-pushed
the
112212-migrate-dialog-wrapper-to-dart
branch
from
156746a to
ea26eaf
Compare
Add methods of FileDialogController Add FileDialogController tests. Change the location where the free of the pointer is placed.
Add methods of FileDialogController Add FileDialogController tests. Extract the interface conversion to a new class to make it testable. Add DialogWrapper constructor. Add test constructor to DialogWrapper and add two tests. Add mock for FileDialogController and tests for implemented methods. free memory allocations remove unused properties in dialog_wrapper use Arena Return the value of the path. fix extension string list to remove trailing semicolon
adpinola
force-pushed
the
112212-migrate-dialog-wrapper-to-dart
branch
from
ea26eaf to
dff1131
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes in #6518.
This finishes the DialogWrapper Dart implementation.
Things we have done:
Issue: [file_selector_windows] Migrate CPP implementation to Dart. #112212
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.