Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Updated plugin channel names to 'plugins.flutter.io/<plugin>' #498

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Updated plugin channel names to 'plugins.flutter.io/<plugin>' #498

merged 1 commit into from
Apr 16, 2018

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Apr 16, 2018 •
edited
Loading

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@goderbauer
Copy link
Member

@bparrishMines Can you format your code with the dart formatter (or apply the diff from travis' format check)? Thanks.

@bparrishMines bparrishMines force-pushed the channel_renames branch 2 times, most recently from 625d59f to 555ec35 Compare April 16, 2018 22:10
goderbauer
goderbauer approved these changes Apr 16, 2018
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines merged commit e644c9e into flutter:master Apr 16, 2018
@bparrishMines bparrishMines deleted the channel_renames branch April 16, 2018 23:12
slightfoot pushed a commit to slightfoot/plugins that referenced this pull request Jun 5, 2018
@bparrishMines @slightfoot
Updated plugin channel names to 'plugins.flutter.io/<plugin>' (flutte…
57e77c5 
…r#498)
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
@bparrishMines
Updated plugin channel names to 'plugins.flutter.io/<plugin>' (flutte…
ad7c1f9 
…r#498)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firebase_storage plugin's channel name should match the other Flutterfire plugins
3 participants
@bparrishMines @googlebot @goderbauer