Updated plugin channel names to 'plugins.flutter.io/<plugin>' (#498)

flutter · Apr 16, 2018 · e644c9e · e644c9e
1 parent dfbe860
commit e644c9e
Show file tree

Hide file tree

Showing 16 changed files with 40 additions and 32 deletions.
diff --git a/packages/firebase_analytics/CHANGELOG.md b/packages/firebase_analytics/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.3.2
+
+* Updated package channel name
+
 ## 0.3.1
 
 * Simplified podspec for Cocoapods 1.5.0, avoiding link issues in app archives.

diff --git a/...s/android/src/main/java/io/flutter/plugins/firebaseanalytics/FirebaseAnalyticsPlugin.java b/...s/android/src/main/java/io/flutter/plugins/firebaseanalytics/FirebaseAnalyticsPlugin.java
@@ -21,7 +21,8 @@ public class FirebaseAnalyticsPlugin implements MethodCallHandler {
   private final FirebaseAnalytics firebaseAnalytics;
 
   public static void registerWith(PluginRegistry.Registrar registrar) {
-    final MethodChannel channel = new MethodChannel(registrar.messenger(), "firebase_analytics");
+    final MethodChannel channel =
+        new MethodChannel(registrar.messenger(), "plugins.flutter.io/firebase_analytics");
     channel.setMethodCallHandler(new FirebaseAnalyticsPlugin(registrar));
   }
 

diff --git a/packages/firebase_analytics/ios/Classes/FirebaseAnalyticsPlugin.m b/packages/firebase_analytics/ios/Classes/FirebaseAnalyticsPlugin.m
@@ -11,7 +11,7 @@ @implementation FLTFirebaseAnalyticsPlugin {
 
 + (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
   FlutterMethodChannel *channel =
-      [FlutterMethodChannel methodChannelWithName:@"firebase_analytics"
+      [FlutterMethodChannel methodChannelWithName:@"plugins.flutter.io/firebase_analytics"
                                   binaryMessenger:[registrar messenger]];
   FLTFirebaseAnalyticsPlugin *instance = [[FLTFirebaseAnalyticsPlugin alloc] init];
   [registrar addMethodCallDelegate:instance channel:channel];

diff --git a/packages/firebase_analytics/lib/firebase_analytics.dart b/packages/firebase_analytics/lib/firebase_analytics.dart
@@ -11,8 +11,8 @@ import 'package:flutter/foundation.dart';
 
 /// Firebase Analytics API.
 class FirebaseAnalytics {
-  static final FirebaseAnalytics _instance =
-      new FirebaseAnalytics.private(const MethodChannel('firebase_analytics'));
+  static final FirebaseAnalytics _instance = new FirebaseAnalytics.private(
+      const MethodChannel('plugins.flutter.io/firebase_analytics'));
 
   /// Provides an instance of this class.
   factory FirebaseAnalytics() => _instance;

diff --git a/packages/firebase_analytics/pubspec.yaml b/packages/firebase_analytics/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for Google Analytics for Firebase, an app measuremen
   solution that provides insight on app usage and user engagement on Android and iOS.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_analytics
-version: 0.3.1
+version: 0.3.2
 
 flutter:
   plugin:

diff --git a/packages/firebase_messaging/CHANGELOG.md b/packages/firebase_messaging/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.2.3
+
+* Updated package channel name
+
 ## 0.2.2
 
 * Simplified podspec for Cocoapods 1.5.0, avoiding link issues in app archives.

diff --git a/...g/android/src/main/java/io/flutter/plugins/firebasemessaging/FirebaseMessagingPlugin.java b/...g/android/src/main/java/io/flutter/plugins/firebasemessaging/FirebaseMessagingPlugin.java
@@ -31,7 +31,8 @@ public class FirebaseMessagingPlugin extends BroadcastReceiver
   private static final String CLICK_ACTION_VALUE = "FLUTTER_NOTIFICATION_CLICK";
 
   public static void registerWith(Registrar registrar) {
-    final MethodChannel channel = new MethodChannel(registrar.messenger(), "firebase_messaging");
+    final MethodChannel channel =
+        new MethodChannel(registrar.messenger(), "plugins.flutter.io/firebase_messaging");
     final FirebaseMessagingPlugin plugin = new FirebaseMessagingPlugin(registrar, channel);
     registrar.addNewIntentListener(plugin);
     channel.setMethodCallHandler(plugin);

diff --git a/packages/firebase_messaging/ios/Classes/FirebaseMessagingPlugin.m b/packages/firebase_messaging/ios/Classes/FirebaseMessagingPlugin.m
@@ -19,7 +19,7 @@ @implementation FLTFirebaseMessagingPlugin {
 
 + (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
   FlutterMethodChannel *channel =
-      [FlutterMethodChannel methodChannelWithName:@"firebase_messaging"
+      [FlutterMethodChannel methodChannelWithName:@"plugins.flutter.io/firebase_messaging"
                                   binaryMessenger:[registrar messenger]];
   FLTFirebaseMessagingPlugin *instance =
       [[FLTFirebaseMessagingPlugin alloc] initWithChannel:channel];

diff --git a/packages/firebase_messaging/lib/firebase_messaging.dart b/packages/firebase_messaging/lib/firebase_messaging.dart
@@ -23,7 +23,8 @@ class FirebaseMessaging {
         _platform = platform;
 
   static final FirebaseMessaging _instance = new FirebaseMessaging.private(
-      const MethodChannel('firebase_messaging'), const LocalPlatform());
+      const MethodChannel('plugins.flutter.io/firebase_messaging'),
+      const LocalPlatform());
 
   final MethodChannel _channel;
   final Platform _platform;

diff --git a/packages/firebase_messaging/pubspec.yaml b/packages/firebase_messaging/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for Firebase Cloud Messaging, a cross-platform
   messaging solution that lets you reliably deliver messages on Android and iOS.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_messaging
-version: 0.2.2
+version: 0.2.3
 
 flutter:
   plugin:

diff --git a/packages/firebase_storage/CHANGELOG.md b/packages/firebase_storage/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.2.3
+
+* Updated package channel name and made channel visible for testing
+
 ## 0.2.2
 
 * Simplified podspec for Cocoapods 1.5.0, avoiding link issues in app archives.

diff --git a/...rage/android/src/main/java/io/flutter/plugins/firebase/storage/FirebaseStoragePlugin.java b/...rage/android/src/main/java/io/flutter/plugins/firebase/storage/FirebaseStoragePlugin.java
@@ -27,7 +27,8 @@ public class FirebaseStoragePlugin implements MethodCallHandler {
   private FirebaseStorage firebaseStorage;
 
   public static void registerWith(Registrar registrar) {
-    final MethodChannel channel = new MethodChannel(registrar.messenger(), "firebase_storage");
+    final MethodChannel channel =
+        new MethodChannel(registrar.messenger(), "plugins.flutter.io/firebase_storage");
     channel.setMethodCallHandler(new FirebaseStoragePlugin(registrar));
   }
 

diff --git a/packages/firebase_storage/ios/Classes/FirebaseStoragePlugin.m b/packages/firebase_storage/ios/Classes/FirebaseStoragePlugin.m
@@ -23,7 +23,7 @@ @implementation FLTFirebaseStoragePlugin {
 
 + (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
   FlutterMethodChannel *channel =
-      [FlutterMethodChannel methodChannelWithName:@"firebase_storage"
+      [FlutterMethodChannel methodChannelWithName:@"plugins.flutter.io/firebase_storage"
                                   binaryMessenger:[registrar messenger]];
   FLTFirebaseStoragePlugin *instance = [[FLTFirebaseStoragePlugin alloc] init];
   [registrar addMethodCallDelegate:instance channel:channel];

diff --git a/packages/firebase_storage/lib/firebase_storage.dart b/packages/firebase_storage/lib/firebase_storage.dart
@@ -9,7 +9,8 @@ import 'dart:typed_data';
 import 'package:flutter/services.dart';
 
 class FirebaseStorage {
-  static const MethodChannel _channel = const MethodChannel('firebase_storage');
+  static const MethodChannel channel =
+      const MethodChannel('plugins.flutter.io/firebase_storage');
 
   static FirebaseStorage get instance => new FirebaseStorage();
 
@@ -39,7 +40,7 @@ class StorageReference {
   /// Asynchronously downloads the object at the StorageReference to a list in memory.
   /// A list of the provided max size will be allocated.
   Future<Uint8List> getData(int maxSize) async {
-    return await FirebaseStorage._channel.invokeMethod(
+    return await FirebaseStorage.channel.invokeMethod(
       "StorageReference#getData",
       <String, dynamic>{
         'maxSize': maxSize,
@@ -49,14 +50,14 @@ class StorageReference {
   }
 
   Future<dynamic> getDownloadURL() async {
-    return await FirebaseStorage._channel
+    return await FirebaseStorage.channel
         .invokeMethod("StorageReference#getDownloadUrl", <String, String>{
       'path': _pathComponents.join("/"),
     });
   }
 
   Future<void> delete() {
-    return FirebaseStorage._channel.invokeMethod("StorageReference#delete",
+    return FirebaseStorage.channel.invokeMethod("StorageReference#delete",
         <String, String>{'path': _pathComponents.join("/")});
   }
 
@@ -73,7 +74,7 @@ class StorageUploadTask {
   Future<UploadTaskSnapshot> get future => _completer.future;
 
   Future<void> _start() async {
-    final String downloadUrl = await FirebaseStorage._channel.invokeMethod(
+    final String downloadUrl = await FirebaseStorage.channel.invokeMethod(
       "StorageReference#putFile",
       <String, String>{
         'filename': file.absolute.path,

diff --git a/packages/firebase_storage/pubspec.yaml b/packages/firebase_storage/pubspec.yaml
@@ -3,7 +3,7 @@ description: Flutter plugin for Firebase Cloud Storage, a powerful, simple, and
   cost-effective object storage service for Android and iOS.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_storage
-version: 0.2.2
+version: 0.2.3
 
 flutter:
   plugin:

diff --git a/packages/firebase_storage/test/firebase_storage_test.dart b/packages/firebase_storage/test/firebase_storage_test.dart
@@ -12,16 +12,13 @@ import 'package:flutter_test/flutter_test.dart';
 void main() {
   group('StorageReference', () {
     group('getData', () {
-      const MethodChannel channel = const MethodChannel(
-        'firebase_storage',
-      );
-
       final List<MethodCall> log = <MethodCall>[];
 
       StorageReference ref;
 
       setUp(() {
-        channel.setMockMethodCallHandler((MethodCall methodCall) {
+        FirebaseStorage.channel
+            .setMockMethodCallHandler((MethodCall methodCall) {
           log.add(methodCall);
           return new Future<Uint8List>.value(
               new Uint8List.fromList(<int>[1, 2, 3, 4]));
@@ -54,16 +51,13 @@ void main() {
     });
 
     group('getDownloadUrl', () {
-      const MethodChannel channel = const MethodChannel(
-        'firebase_storage',
-      );
-
       final List<MethodCall> log = <MethodCall>[];
 
       StorageReference ref;
 
       setUp(() {
-        channel.setMockMethodCallHandler((MethodCall methodCall) async {
+        FirebaseStorage.channel
+            .setMockMethodCallHandler((MethodCall methodCall) async {
           log.add(methodCall);
           return 'https://path/to/file';
         });
@@ -93,16 +87,13 @@ void main() {
     });
 
     group('delete', () {
-      const MethodChannel channel = const MethodChannel(
-        'firebase_storage',
-      );
-
       final List<MethodCall> log = <MethodCall>[];
 
       StorageReference ref;
 
       setUp(() {
-        channel.setMockMethodCallHandler((MethodCall methodCall) async {
+        FirebaseStorage.channel
+            .setMockMethodCallHandler((MethodCall methodCall) async {
           log.add(methodCall);
           return null;
         });