Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera]refactor FLTCam outside of CameraPlugin #4708

Merged
merged 5 commits into from
Jan 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/camera/camera/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## NEXT

* Minor iOS internal code cleanup related to camera class and its delegate.
* Minor iOS internal code cleanup related to resolution preset, video format, focus mode, exposure mode and device orientation.
* Minor iOS internal code cleanup related to flash mode.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,11 @@
// found in the LICENSE file.

@import camera;
@import camera.Test;
@import XCTest;
@import AVFoundation;
#import <OCMock/OCMock.h>

// Mirrors FocusMode in camera.dart
typedef enum {
FocusModeAuto,
FocusModeLocked,
} FocusMode;

@interface FLTCam : NSObject <FlutterTexture,
AVCaptureVideoDataOutputSampleBufferDelegate,
AVCaptureAudioDataOutputSampleBufferDelegate>

- (void)applyFocusMode;
- (void)applyFocusMode:(FocusMode)focusMode onDevice:(AVCaptureDevice *)captureDevice;
- (void)setFocusPointWithResult:(FLTThreadSafeFlutterResult *)result x:(double)x y:(double)y;
@end

@interface CameraFocusTests : XCTestCase
@property(readonly, nonatomic) FLTCam *camera;
@property(readonly, nonatomic) id mockDevice;
Expand Down Expand Up @@ -51,7 +37,7 @@ - (void)testAutoFocusWithContinuousModeSupported_ShouldSetContinuousAutoFocus {
[[_mockDevice reject] setFocusMode:AVCaptureFocusModeAutoFocus];

// Run test
[_camera applyFocusMode:FocusModeAuto onDevice:_mockDevice];
[_camera applyFocusMode:FLTFocusModeAuto onDevice:_mockDevice];

// Expect setFocusMode:AVCaptureFocusModeContinuousAutoFocus
OCMVerify([_mockDevice setFocusMode:AVCaptureFocusModeContinuousAutoFocus]);
Expand All @@ -68,7 +54,7 @@ - (void)testAutoFocusWithContinuousModeNotSupported_ShouldSetAutoFocus {
[[_mockDevice reject] setFocusMode:AVCaptureFocusModeContinuousAutoFocus];

// Run test
[_camera applyFocusMode:FocusModeAuto onDevice:_mockDevice];
[_camera applyFocusMode:FLTFocusModeAuto onDevice:_mockDevice];

// Expect setFocusMode:AVCaptureFocusModeAutoFocus
OCMVerify([_mockDevice setFocusMode:AVCaptureFocusModeAutoFocus]);
Expand All @@ -86,7 +72,7 @@ - (void)testAutoFocusWithNoModeSupported_ShouldSetNothing {
[[_mockDevice reject] setFocusMode:AVCaptureFocusModeAutoFocus];

// Run test
[_camera applyFocusMode:FocusModeAuto onDevice:_mockDevice];
[_camera applyFocusMode:FLTFocusModeAuto onDevice:_mockDevice];
}

- (void)testLockedFocusWithModeSupported_ShouldSetModeAutoFocus {
Expand All @@ -99,7 +85,7 @@ - (void)testLockedFocusWithModeSupported_ShouldSetModeAutoFocus {
[[_mockDevice reject] setFocusMode:AVCaptureFocusModeContinuousAutoFocus];

// Run test
[_camera applyFocusMode:FocusModeLocked onDevice:_mockDevice];
[_camera applyFocusMode:FLTFocusModeLocked onDevice:_mockDevice];

// Expect setFocusMode:AVCaptureFocusModeAutoFocus
OCMVerify([_mockDevice setFocusMode:AVCaptureFocusModeAutoFocus]);
Expand All @@ -116,7 +102,7 @@ - (void)testLockedFocusWithModeNotSupported_ShouldSetNothing {
[[_mockDevice reject] setFocusMode:AVCaptureFocusModeAutoFocus];

// Run test
[_camera applyFocusMode:FocusModeLocked onDevice:_mockDevice];
[_camera applyFocusMode:FLTFocusModeLocked onDevice:_mockDevice];
}

- (void)testSetFocusPointWithResult_SetsFocusPointOfInterest {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,12 @@
// found in the LICENSE file.

@import camera;
@import camera.Test;
@import XCTest;
@import AVFoundation;
#import <OCMock/OCMock.h>
#import "MockFLTThreadSafeFlutterResult.h"

@interface FLTCam : NSObject <FlutterTexture,
AVCaptureVideoDataOutputSampleBufferDelegate,
AVCaptureAudioDataOutputSampleBufferDelegate>
@property(assign, nonatomic) BOOL isPreviewPaused;

- (void)pausePreviewWithResult:(FLTThreadSafeFlutterResult *)result;

- (void)resumePreviewWithResult:(FLTThreadSafeFlutterResult *)result;
@end

@interface CameraPreviewPauseTests : XCTestCase
@end

Expand Down
Loading