This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[camera]refactor FLTCam outside of CameraPlugin #4708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
requested review from
jmagman,
stuartmorgan-g and
cyanglaz
and removed request for
bparrishMines
jmagman
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Note that this
FLTCamclass is huge, so I'd prefer to scope this PR to just moving the code. But it's worth pointing out thatFLTCamhas multiple style issues not addressed by this PR, for example, missing comments on each properties and methods, missing most unit tests, etc.
👍 LGTM
hellohuanlin
added
the
waiting for tree to go green
@hellohuanlin can you file an issue for the |
I filed this a while ago flutter/flutter#95594 |
Ah thanks I couldn't find it. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
FLTCam(and its companion classes) to a separate file, and updates the unit tests to remove dummy FLTCam interface.Note that this
FLTCamclass is huge, so I'd prefer to scope this PR to just moving the code. But it's worth pointing out thatFLTCamhas multiple style issues not addressed by this PR, for example, missing comments on each properties and methods, missing most unit tests, etc.This PR should conclude the "Breakup CameraPlugin.m" subtask in flutter/flutter#96429
No version change: just moving code to separate files.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.