Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Remove dependency on flutter.dev and google.com (Android/WKWebView) #4707

Merged

Conversation

BeMacized
Copy link
Contributor

@BeMacized BeMacized commented Jan 27, 2022

This is a follow up PR to this one:

It applies the same changes that were made to the integration tests for the app facing package, to the identical integration tests in the webview_flutter_android and webview_flutter_wkwebview packages.

Part of flutter/flutter#95420

No CHANGELOG change: refactoring tests

@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-android platform-ios labels Jan 27, 2022
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I added the same CHANGELOG override comment to the PR description; you'll just need to push some kind of update (e.g., amend the commit to make a trivial change to the commit message, then force push) to get the publishable check to pass.

@BeMacized BeMacized force-pushed the webview/integration_webserver_native branch from dcd43ef to 1850341 Compare January 27, 2022 15:20
@BeMacized BeMacized added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jan 27, 2022
@BeMacized BeMacized merged commit df0ed4c into flutter:main Jan 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p: webview_flutter Edits files for a webview_flutter plugin platform-android platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants