This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Remove dependency on flutter.dev and google.com #4691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
p: webview_flutter
Hixie
force-pushed
the
localweb
branch
2 times, most recently
from
a9278d8 to
097d15c
Compare
Hixie
changed the title
stuartmorgan-g
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
LGTM! This is great :)
We'll need to duplicate this to the integration tests for the implementation packages (they are ~duplicates of this file; long story); you can either add that to this PR (https://github.com/flutter/plugins/search?q=primaryurl), or I can do it in a follow-up.
|
I'm loathe to be a bottleneck so I'm going to let you run with this. :-) |
Hixie
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2022
This was referenced Jan 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No CHANGELOG change: refactoring tests