Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Fix CHANGELOG for 0.2.0. #4517

Merged
merged 2 commits into from
Nov 18, 2021
Merged

[in_app_purchase] Fix CHANGELOG for 0.2.0. #4517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f1b40f
Fix CHANGELOG for 0.2.0.
mvanbeusekom Nov 17, 2021
b2ad87b
Applied feedback from PR
mvanbeusekom Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/in_app_purchase/in_app_purchase_ios/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
## 0.2.0+1

* Fixes CHANGELOG for 0.2.0 (added missing information regarding the implementation of promotional offers).

## 0.2.0

* BREAKING CHANGE : Refactor to handle new `PurchaseStatus` named `canceled`. This means developers
can distinguish between an error and user cancellation.
can distinguish between an error and user cancellation;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change from . to ;? This was right before.

Copy link
Contributor Author

@mvanbeusekom mvanbeusekom Nov 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it is no longer the last element in the list. In Dutch you add a semi-colon for each item in the list except for the last item which ends with a period to indicate the end of the list. I always thought this is the same in English.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Nov 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've never treated the changelog as a single-sentence list grammatically, but as a series of independent sentences. Otherwise the capitalization would be wrong, and multi-sentence entries (like this one, in fact) would be very strange.

* Adds support for promotional offers on the store_kit_wrappers Dart API.

## 0.1.4

Expand Down
2 changes: 1 addition & 1 deletion packages/in_app_purchase/in_app_purchase_ios/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: in_app_purchase_ios
description: An implementation for the iOS platform of the Flutter `in_app_purchase` plugin. This uses the iOS StoreKit Framework.
repository: https://github.com/flutter/plugins/tree/master/packages/in_app_purchase/in_app_purchase_ios
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+in_app_purchase%22
version: 0.2.0
version: 0.2.0+1

environment:
sdk: ">=2.14.0 <3.0.0"
Expand Down