-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[in_app_purchase] Fix CHANGELOG for 0.2.0. #4517
[in_app_purchase] Fix CHANGELOG for 0.2.0. #4517
Conversation
It's not obvious from the link, but this is actually test-exempt (as evidenced by the bot not commenting); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
## 0.2.0 | ||
|
||
* BREAKING CHANGE : Refactor to handle new `PurchaseStatus` named `canceled`. This means developers | ||
can distinguish between an error and user cancellation. | ||
can distinguish between an error and user cancellation; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change from .
to ;
? This was right before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it is no longer the last element in the list. In Dutch you add a semi-colon for each item in the list except for the last item which ends with a period to indicate the end of the list. I always thought this is the same in English.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've never treated the changelog as a single-sentence list grammatically, but as a series of independent sentences. Otherwise the capitalization would be wrong, and multi-sentence entries (like this one, in fact) would be very strange.
PR #4458 was merged without having the version updated and the functionality is now published as part of in_app_purchase_ios version 0.2.0 (that was release with PR #4094).
This PR adds a belated correction to version 0.2.0 in the CHANGELOG to ensure the changes made in #4458 don't go undocumented.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.