Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Fix CHANGELOG for 0.2.0. #4517

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

mvanbeusekom
Copy link
Contributor

@mvanbeusekom mvanbeusekom commented Nov 17, 2021

PR #4458 was merged without having the version updated and the functionality is now published as part of in_app_purchase_ios version 0.2.0 (that was release with PR #4094).

This PR adds a belated correction to version 0.2.0 in the CHANGELOG to ensure the changes made in #4458 don't go undocumented.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
    • Only a documentation change in the CHANGELOG.md and a corresponding version bump in pubspec.yaml. So no new tests were added.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@stuartmorgan-g
Copy link
Contributor

[ ] I added new tests to check the change I am making, or this PR is test-exempt.

  • Only a documentation change in the CHANGELOG.md and a corresponding version bump in pubspec.yaml. So no new tests were added.

It's not obvious from the link, but this is actually test-exempt (as evidenced by the bot not commenting); pubspec.yaml is considered okay by the bot, even though it's not listed on the wiki (I'll ask Hixie about that, actually). So you can check the box.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

@mvanbeusekom mvanbeusekom added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Nov 17, 2021
## 0.2.0

* BREAKING CHANGE : Refactor to handle new `PurchaseStatus` named `canceled`. This means developers
can distinguish between an error and user cancellation.
can distinguish between an error and user cancellation;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change from . to ;? This was right before.

Copy link
Contributor Author

@mvanbeusekom mvanbeusekom Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since it is no longer the last element in the list. In Dutch you add a semi-colon for each item in the list except for the last item which ends with a period to indicate the end of the list. I always thought this is the same in English.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've never treated the changelog as a single-sentence list grammatically, but as a series of independent sentences. Otherwise the capitalization would be wrong, and multi-sentence entries (like this one, in fact) would be very strange.

@fluttergithubbot fluttergithubbot merged commit 88c69ed into flutter:master Nov 18, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 18, 2021
@mvanbeusekom mvanbeusekom deleted the iap/correct_changelog branch November 30, 2021 08:32
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: in_app_purchase platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants