This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter] add todo on skipped test. #2752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 12, 2020 15:06
cyanglaz
changed the title
blasten
reviewed
May 12, 2020
| @@ -940,5 +940,8 @@ void main() { | |||
| final GoogleMapInspector inspector = await inspectorCompleter.future; | |||
| final Uint8List bytes = await inspector.takeSnapshot(); | |||
| expect(bytes?.isNotEmpty, true); | |||
| }, skip: Platform.isAndroid); | |||
| }, | |||
| //TODO(cyanglaz): un-skip the test when we can test this on CI with API key enabled. | |||
blasten
approved these changes
May 12, 2020
blasten
reviewed
May 12, 2020
| //TODO(cyanglaz): un-skip the test when we can test this on CI with API key enabled. | ||
| //https://github.com/flutter/flutter/issues/57057 | ||
| // TODO(cyanglaz): un-skip the test when we can test this on CI with API key enabled. | ||
| // https://github.com/flutter/flutter/issues/57057 | ||
| skip: Platform.isAndroid); |
There was a problem hiding this comment.
true. It was formatted by the formatter tho.
mgonzalezc
pushed a commit
to mgonzalezc/plugins
that referenced
this pull request
May 19, 2020
* master: (96 commits) Update README.md (flutter#2768) [url_launcher_web] Launch mailto urls in same window in Safari (flutter#2740) update README with enableJavaScript info (flutter#2766) Run publish ci check on master (flutter#2764) [image_picker] Add documentation for Android external storage permissions (flutter#2765) [package_info] add support for macos to package_info plugin (flutter#2618) fixed detach from engine logic (flutter#2759) [url_launcher] Initialize previousAutomaticSystemUiAdjustment in launch (flutter#2757) [google_maps_flutter] add todo on skipped test. (flutter#2752) [google_maps_flutter] use `WaitUntilTouchesEndedPolicy` to fix the cameraIdle not called issue on iOS (flutter#2746) Use Xvfb for Linux desktop tests (flutter#2750) update lower dart bound to 2.1.0 (flutter#2751) [camera] Update lower bound of dart dependency to 2.1.0. (flutter#2749) [battery] update dart deps lower bound to 2.1.0 (flutter#2748) [android_alarm_manager] update dart deps lower bound to 2.1.0 (flutter#2747) [url_launcher] Add web to example app. (flutter#2736) [in_app_purchase] update docs to warn about `completePurchase` (flutter#2739) [video_player] upgraded video_player to use pigeon (flutter#2544) [video_player]: fixed platform_interface unit tests (flutter#2745) [video_player]: added test class to fix video_player unit tests (flutter#2744) ... # Conflicts: # packages/quick_actions/ios/Classes/FLTQuickActionsPlugin.m
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
un-skip the test that was accidentally skipped in #2746
The last PR hasn't published yet so we don't need to update the version here.