[camera_avfoundation] Fix incorrect types in image stream events

[RobertOdrowaz]

Fixes the types used in the image stream events. Most importantly, it corrects the lensAperture to lensAperture**()** that caused a crash. Some other arguments were also updated to match exactly the types expected by the parsing in type_conversions.dart.

Resolves: flutter/flutter#170240

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[stuartmorgan-g]

Maybe it's out of scope for this PR, but now that this file is Swift the event channel could be converted to a Pigeon event channel. That would make this class of bug impossible here, because we'd have actual type checking.

[RobertOdrowaz]

Maybe it's out of scope for this PR, but now that this file is Swift the event channel could be converted to a Pigeon event channel. That would make this class of bug impossible here, because we'd have actual type checking.

I agree 100%, but I wanted to fix this ASAP because it seems to affect a number of people. I will open an issue for the pigeon refactor

[stuartmorgan-g]

I just noticed that the Pigeon generation is still Obj-C, so switching to Pigeon event channels would be a much bigger change than I had realized. Definitely out of scope here!

[RobertOdrowaz]

@hellohuanlin Take a look at this PR, please. I would like to resolve this issue and move forward with the migration

[hellohuanlin]

was it trying to convert a closure (memory address) to double?

[hellohuanlin]

@RobertOdrowaz is this ready to land?

[RobertOdrowaz]

It is, I'm just waiting for the tree to get green again. BTW does auto-submit take the tree status into account? I assume it does, but I wasn't sure, so I didn't add it

[hellohuanlin]

does auto-submit take the tree status into account?

Yep