[go_router] fix: PopScope.onPopInvokedWithResult not called in branch routes #9245
+162
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Gustl22
force-pushed
the
138737-go-router-pop-scope
branch
from
4dc074a to
f2b12ec
Compare
chunhtai
reviewed
May 16, 2025
| if (potentialCandidate.canPop()) { | ||
| state = walker.navigatorKey.currentState; | ||
| } | ||
| states.insert(0, potentialCandidate); |
There was a problem hiding this comment.
you can do a reversed at the end
There was a problem hiding this comment.
Thanks, I updated the code to use reversed and iterable as return type.
…p-scope # Conflicts: # packages/go_router/CHANGELOG.md
…p-scope # Conflicts: # packages/go_router/CHANGELOG.md
|
@chunhtai any chance to have this get merged ;D Thx in advance :D |
…p-scope # Conflicts: # packages/go_router/CHANGELOG.md # packages/go_router/pubspec.yaml
|
@chunhtai @hannah-hyj reminder to get this merged. Unfortunately, as I am not part of that organization, I cannot add the autosubmit label. |
Ack! This will likely have a merge conflict once #8352 lands. I should be able to fix the conflict here and get this merged once that one lands. |
11 tasks
Piinks
reviewed
Jun 18, 2025
Piinks
reviewed
Jun 18, 2025
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/9245, because - The status or check suite Linux_android android_build_all_packages master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Thank you @Piinks for landing this 🎉 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 19, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 19, 2025
flutter/packages@715a0a5...0ec4053 2025-06-19 engine-flutter-autoroll@skia.org Roll Flutter from 8303a96 to 85a9b4f (93 revisions) (flutter/packages#9457) 2025-06-19 32538273+ValentinVignal@users.noreply.github.com [go_router] Update sype safe routing topic to use mixin from go_router_builder 3.0.0 (flutter/packages#9422) 2025-06-19 august.oberhauser@swissinfo.ch [go_router] fix: PopScope.onPopInvokedWithResult not called in branch routes (flutter/packages#9245) 2025-06-18 10687576+bparrishMines@users.noreply.github.com [pigeon] Create a message call free InstanceManager when running unit tests (flutter/packages#9395) 2025-06-18 737941+loic-sharma@users.noreply.github.com [go_router] Use library prefix for meta (flutter/packages#9434) 2025-06-18 41765610+ahyangnb@users.noreply.github.com [go_router] fix Popping state and re-rendering scaffold at the same time doesn't update the URL on web [new] (flutter/packages#8352) 2025-06-18 robert.odrowaz@leancode.pl [camera_avfoundation] Fix incorrect types in image stream events (flutter/packages#9418) 2025-06-18 stuartmorgan@google.com [go_router_builder] Temporarily restrict `build` (flutter/packages#9453) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using
PopScopeinsideStatefulShellRoute.indexedStackit is not called when on top most route.flutter/flutter#138737 (comment)
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3