[webview_flutter] Fix macOS test issues and skip some legacy iOS tests #8895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vashworth
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 25, 2025
flutter/packages@c27d2fe...125c117 2025-03-25 joonas.kerttula@codemate.com [google_maps_flutter] Add ability to animate camera with duration (flutter/packages#7648) 2025-03-24 15619084+vashworth@users.noreply.github.com [webview_flutter] Fix macOS test issues and skip some legacy iOS tests (flutter/packages#8895) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
I previously skipped these tests in `webview_flutter_wkwebview` example app (#8895), but need to also skip in the `webview_flutter` example app. Temporary solution for flutter/flutter#164632. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
vashworth
added a commit
to vashworth/packages
that referenced
this pull request
Mar 31, 2025
I previously skipped these tests in `webview_flutter_wkwebview` example app (flutter#8895), but need to also skip in the `webview_flutter` example app. Temporary solution for flutter/flutter#164632. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
CodixNinja
pushed a commit
to CodixNinja/packages
that referenced
this pull request
May 15, 2025
I previously skipped these tests in `webview_flutter_wkwebview` example app (flutter/packages#8895), but need to also skip in the `webview_flutter` example app. Temporary solution for flutter/flutter#164632. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
flutter#8895) Tests on macOS were [failing](flutter/flutter#164632 (comment)) due to `videoTestBase64` not being initialized. This PR moved `videoTestBase64` initialization into each individual test. Tests on macOS were [failing](flutter/flutter#164632 (comment)) due matching failing because on some devices JavaScript turns a boolean as a string like `"false"` and sometimes as a number like `"0"`. This PR changes it to accept either regardless of device. Some legacy iOS tests are [flaking](flutter/flutter#164632 (comment)) with Xcode 16, so we're skipping them for now. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
I previously skipped these tests in `webview_flutter_wkwebview` example app (flutter#8895), but need to also skip in the `webview_flutter` example app. Temporary solution for flutter/flutter#164632. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
zhangyuang
pushed a commit
to zhangyuang/flutter-fork
that referenced
this pull request
Jun 9, 2025
…r#165884) flutter/packages@c27d2fe...125c117 2025-03-25 joonas.kerttula@codemate.com [google_maps_flutter] Add ability to animate camera with duration (flutter/packages#7648) 2025-03-24 15619084+vashworth@users.noreply.github.com [webview_flutter] Fix macOS test issues and skip some legacy iOS tests (flutter/packages#8895) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
flutter#8895) Tests on macOS were [failing](flutter/flutter#164632 (comment)) due to `videoTestBase64` not being initialized. This PR moved `videoTestBase64` initialization into each individual test. Tests on macOS were [failing](flutter/flutter#164632 (comment)) due matching failing because on some devices JavaScript turns a boolean as a string like `"false"` and sometimes as a number like `"0"`. This PR changes it to accept either regardless of device. Some legacy iOS tests are [flaking](flutter/flutter#164632 (comment)) with Xcode 16, so we're skipping them for now. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
I previously skipped these tests in `webview_flutter_wkwebview` example app (flutter#8895), but need to also skip in the `webview_flutter` example app. Temporary solution for flutter/flutter#164632. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Jyndigo
pushed a commit
to uesp/wkwebview_flutter
that referenced
this pull request
Jun 24, 2025
I previously skipped these tests in `webview_flutter_wkwebview` example app (flutter/packages#8895), but need to also skip in the `webview_flutter` example app. Temporary solution for flutter/flutter#164632. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…r#165884) flutter/packages@c27d2fe...125c117 2025-03-25 joonas.kerttula@codemate.com [google_maps_flutter] Add ability to animate camera with duration (flutter/packages#7648) 2025-03-24 15619084+vashworth@users.noreply.github.com [webview_flutter] Fix macOS test issues and skip some legacy iOS tests (flutter/packages#8895) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests on macOS were failing due to
videoTestBase64not being initialized. This PR movedvideoTestBase64initialization into each individual test.Tests on macOS were failing due matching failing because on some devices JavaScript turns a boolean as a string like
"false"and sometimes as a number like"0". This PR changes it to accept either regardless of device.Some legacy iOS tests are flaking with Xcode 16, so we're skipping them for now.
Pre-Review Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3