[google_maps_flutter] Add ability to animate camera with duration #7648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: google_maps_flutter
platform-android
platform-ios
platform-web
labels
jokerttu
force-pushed
the
feature/animate-camera-duration
branch
from
fbf20bc to
68e52df
Compare
jokerttu
changed the title
jokerttu
force-pushed
the
feature/animate-camera-duration
branch
from
68e52df to
2c8caf1
Compare
jokerttu
force-pushed
the
feature/animate-camera-duration
branch
2 times, most recently
from
2256a07 to
c39c721
Compare
jokerttu
requested review from
cbracken,
ditman,
reidbaker and
stuartmorgan-g
as code owners
stuartmorgan-g
added
the
federated: all_changes
stuartmorgan-g
requested changes
Nov 7, 2024
...ps_flutter_platform_interface/lib/src/method_channel/method_channel_google_maps_flutter.dart
Outdated
Show resolved
Hide resolved
...ps_flutter_platform_interface/lib/src/method_channel/method_channel_google_maps_flutter.dart
Outdated
Show resolved
Hide resolved
...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart
Outdated
Show resolved
Hide resolved
...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter/lib/google_maps_flutter.dart
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/pigeons/messages.dart
Outdated
Show resolved
Hide resolved
.../google_maps_flutter/google_maps_flutter_ios/example/ios14/ios/RunnerTests/GoogleMapsTests.m
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/pigeons/messages.dart
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_web/lib/src/google_maps_flutter_web.dart
Outdated
Show resolved
Hide resolved
...flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java
Outdated
Show resolved
Hide resolved
jokerttu
force-pushed
the
feature/animate-camera-duration
branch
from
7c30a33 to
167b519
Compare
jokerttu
force-pushed
the
feature/animate-camera-duration
branch
from
167b519 to
6078134
Compare
jokerttu
force-pushed
the
feature/animate-camera-duration
branch
2 times, most recently
from
eb71ec7 to
b6807ec
Compare
stuartmorgan-g
added
triage-ios
stuartmorgan-g
requested changes
Nov 22, 2024
...le_maps_flutter/google_maps_flutter_ios/example/ios14/integration_test/google_maps_test.dart
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMCATransactionWrapper.h
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMCATransactionWrapper.h
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/FGMCATransactionWrapper.m
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController_Test.h
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController_Test.h
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController_Test.h
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_ios/test/google_maps_flutter_ios_test.dart
Outdated
Show resolved
Hide resolved
.../google_maps_flutter/google_maps_flutter_ios/example/ios14/ios/RunnerTests/GoogleMapsTests.m
Outdated
Show resolved
Hide resolved
|
My comments are all minor, so once the iOS and Android reviewers have signed off this will be ready to split out the first sub-PR. |
jokerttu
force-pushed
the
feature/animate-camera-duration
branch
from
b6807ec to
6bc7717
Compare
jokerttu
force-pushed
the
feature/animate-camera-duration
branch
from
261d5b0 to
028c147
Compare
jokerttu
force-pushed
the
feature/animate-camera-duration
branch
from
028c147 to
32c21af
Compare
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
…latform impls (#8659) This PR contains platform implementations for the ability to animate camera with duration (#7648). Linked issue: flutter/flutter#39810 Linked issue: flutter/flutter#44284
jokerttu
force-pushed
the
feature/animate-camera-duration
branch
from
32c21af to
565b4c3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
@stuartmorgan this PR now contains only app-facing package changes |
jokerttu
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 25, 2025
flutter/packages@c27d2fe...125c117 2025-03-25 joonas.kerttula@codemate.com [google_maps_flutter] Add ability to animate camera with duration (flutter/packages#7648) 2025-03-24 15619084+vashworth@users.noreply.github.com [webview_flutter] Fix macOS test issues and skip some legacy iOS tests (flutter/packages#8895) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dko5ki23t
pushed a commit
to dko5ki23t/google_maps_flutter_improved
that referenced
this pull request
May 24, 2025
…n (#8596) This PR contains platform interface changes for support to adjust camera animation speed (flutter/packages#7648). Linked issue: flutter/flutter#39810 Linked issue: flutter/flutter#44284
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
flutter#8596) This PR contains platform interface changes for support to adjust camera animation speed (flutter#7648). Linked issue: flutter/flutter#39810 Linked issue: flutter/flutter#44284
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…latform impls (flutter#8659) This PR contains platform implementations for the ability to animate camera with duration (flutter#7648). Linked issue: flutter/flutter#39810 Linked issue: flutter/flutter#44284
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…utter#7648) Adds ability to configure camera animation duration on Android and iOS. Resolves [#39810](flutter/flutter#39810) Resolves [#44284](flutter/flutter#44284)
zhangyuang
pushed a commit
to zhangyuang/flutter-fork
that referenced
this pull request
Jun 9, 2025
…r#165884) flutter/packages@c27d2fe...125c117 2025-03-25 joonas.kerttula@codemate.com [google_maps_flutter] Add ability to animate camera with duration (flutter/packages#7648) 2025-03-24 15619084+vashworth@users.noreply.github.com [webview_flutter] Fix macOS test issues and skip some legacy iOS tests (flutter/packages#8895) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
flutter#8596) This PR contains platform interface changes for support to adjust camera animation speed (flutter#7648). Linked issue: flutter/flutter#39810 Linked issue: flutter/flutter#44284
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…latform impls (flutter#8659) This PR contains platform implementations for the ability to animate camera with duration (flutter#7648). Linked issue: flutter/flutter#39810 Linked issue: flutter/flutter#44284
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…utter#7648) Adds ability to configure camera animation duration on Android and iOS. Resolves [#39810](flutter/flutter#39810) Resolves [#44284](flutter/flutter#44284)
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…r#165884) flutter/packages@c27d2fe...125c117 2025-03-25 joonas.kerttula@codemate.com [google_maps_flutter] Add ability to animate camera with duration (flutter/packages#7648) 2025-03-24 15619084+vashworth@users.noreply.github.com [webview_flutter] Fix macOS test issues and skip some legacy iOS tests (flutter/packages#8895) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to configure camera animation duration on Android and iOS.
Resolves #39810
Resolves #44284
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.