Skip to content

[local_auth]: Bump androidx.core:core from 1.13.1 to 1.15.0 in /packages/local_auth/local_auth_android/android #7985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 31, 2024

Bumps androidx.core:core from 1.13.1 to 1.15.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps androidx.core:core from 1.13.1 to 1.15.0.

---
updated-dependencies:
- dependency-name: androidx.core:core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from camsim99 as a code owner October 31, 2024 17:37
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 31, 2024
@camsim99
Copy link
Contributor

This at least requires a bump to 35

@camsim99
Copy link
Contributor

camsim99 commented Dec 9, 2024

The example app needs a bump to 35 I think?

@jmagman
Copy link
Member

jmagman commented Dec 20, 2024

The example app needs a bump to 35 I think?

if (gradleFileIsKotlin)
'compileSdk': <String>['compileSdk = 34']
else ...<String, List<String>>{
'compileSdkVersion': <String>['compileSdk 34'],
}

@reidbaker mentioned it should be 35
https://github.com/flutter/packages/pull/7891/files#r1815169527

But should it instead be flutter.compileSdkVersion (which is currently 35) so it doesn't have to be chased?

@reidbaker
Copy link
Contributor

The example app needs a bump to 35 I think?

if (gradleFileIsKotlin)
'compileSdk': <String>['compileSdk = 34']
else ...<String, List<String>>{
'compileSdkVersion': <String>['compileSdk 34'],
}

@reidbaker mentioned it should be 35 https://github.com/flutter/packages/pull/7891/files#r1815169527

But should it instead be flutter.compileSdkVersion (which is currently 35) so it doesn't have to be chased?

I think this all packages forces version so that older compile sdk flutter versions and newer use the same compile sdk version since I think this test runs on stable and master. It is harder to keep one app in a state that can have multiple compile sdk versions.

I will make a pr to update https://github.com/flutter/flutter/blob/188d1e1999c7dd2804d3802976248fdad12d4372/docs/platforms/android/New-Android-version.md?plain=1 with a link to this code.

github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 20, 2024
No issue
Related to
flutter/packages#7985 (comment)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 20, 2024
No issue
Related to
flutter/packages#7985 (comment)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
@jmagman
Copy link
Member

jmagman commented Dec 20, 2024

I think this all packages forces version so that older compile sdk flutter versions and newer use the same compile sdk version since I think this test runs on stable and master.

The example apps all use flutter.compileSdkVersion even though they run on stable and master, and the all packages test seems like it's spiritually similar to the example apps, in that it's checking that an app with all the plugins included still builds. The legacy one would maybe have different constraints though.

@reidbaker
Copy link
Contributor

I think this all packages forces version so that older compile sdk flutter versions and newer use the same compile sdk version since I think this test runs on stable and master.

The example apps all use flutter.compileSdkVersion even though they run on stable and master, and the all packages test seems like it's spiritually similar to the example apps, in that it's checking that an app with all the plugins included still builds. The legacy one would maybe have different constraints though.

That is a good point. We can migrate it to flutter.compileSdkVersion and ask stuart if there was a reason we missed when he is back.

@Piinks
Copy link
Contributor

Piinks commented Mar 11, 2025

Greetings from triage - is this PR still one we want to move forward with?

@reidbaker reidbaker closed this Mar 12, 2025
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 12, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/packages/local_auth/local_auth_android/android/androidx.core-core-1.15.0 branch March 12, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code p: local_auth platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants