[tool] Build all_packages command against Flutter Android SDK version to match example app compileSdk constraints

[jmagman]

A few dependency bumps are failing due to the all_packages test targeting a lower version of Android SDK than the example apps. Instead of hardcoding an SDK version which needs to be updated manually (https://github.com/flutter/packages/pull/7891/files#r1815169527), instead use flutter.compileSdkVersion, similar to #3847.

Unblocks attempts to increase dependencies versions that require SDK 35 or higher
#7985

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[jmagman]

 │ [!] Using compileSdk 35 requires Android Gradle Plugin (AGP) 8.1.0 or higher.                    

[jmagman]

packages/.ci/legacy_project/all_packages/android/gradle/wrapper/gradle-wrapper.properties

Line 6 in 864e6be

distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-all.zip

Bump like #6742

[jmagman]

Error now is that the legacy variant is using a lower version of AGP and needs 8.1

[!] Using compileSdk 35 requires Android Gradle Plugin (AGP) 8.1.0 or higher. │
│ Please upgrade to a newer AGP version. The version of AGP that your project uses is likely │
│ defined in: │
│ /b/s/w/ir/x/w/packages/legacy/all_packages/android/settings.gradle, │
│ in the 'plugins' closure (by the number following "com.android.application"). │
│ Alternatively, if your project was created with an older version of the templates, it is likely │
│ in the buildscript.dependencies closure of the top-level build.gradle: │
│ /b/s/w/ir/x/w/packages/legacy/all_packages/android/build.gradle, │
│ as the number following "com.android.tools.build:gradle:".

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8727714051273194977/+/u/Run_package_tests/build_all_packages_for_Android_-_legacy_version/stdout

[gmackall]

From triage: Is one of these the legacy file? If so, can we make that file use compileSdk 35 (just copying discussion from internal conversation).

[gmackall]

Also, can we eliminate this conditional logic by just using compileSdk = 35 in both cases? I think that is valid Groovy as well as Kotlin

[jmagman]

I could swap them both to compileSdk since compileSdkVersion is deprecated.
Never mind, that didn't make sense. I see what you mean.

[camsim99]

Note from Android triage: @jmagman are you still working on this?

[Piinks]

Greetings from stale PR triage 👋 @jmagman is this still on your radar?

[jmagman]

Closing this, I haven't gotten back to it.