Skip to content

[interactive_media_ads] Adds internal wrapper for Android native CompanionAd #7823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Oct 8, 2024

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines changed the title Ima android companion [interactive_media_ads] Adds internal wrapper for Android native CompanionAd Oct 8, 2024
@bparrishMines bparrishMines marked this pull request as ready for review October 8, 2024 18:29
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 9, 2024
@auto-submit auto-submit bot merged commit 9d00fb1 into flutter:main Oct 9, 2024
76 checks passed
@bparrishMines bparrishMines deleted the ima_android_companion branch October 9, 2024 03:02
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 9, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 9, 2024
flutter/packages@8fbf4cd...9d00fb1

2024-10-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for Android native `CompanionAd` (flutter/packages#7823)
2024-10-08 matanlurey@users.noreply.github.com Disable `SurfaceProducer.Callback` when the surface is disposed manually. (flutter/packages#7827)
2024-10-08 matanlurey@users.noreply.github.com Dispose the `ExoPlayer` before `SurfaceProducer`. (flutter/packages#7824)
2024-10-08 stuartmorgan@google.com [pigeon] Use non-nullable generics in example app (flutter/packages#7817)
2024-10-08 43054281+camsim99@users.noreply.github.com Manually Roll Flutter (stable) from 4cf269e to 2663184 (5 revisions) (flutter/packages#7819)
2024-10-08 stuartmorgan@google.com [camera] Update iOS Pigeon for non-nullable generics (flutter/packages#7787)
2024-10-08 stuartmorgan@google.com [in_app_purchase] Update Android Pigeon for non-nullable generics (flutter/packages#7788)
2024-10-08 jessiewong401@gmail.com [WIP] Updated applying gradle plugin for flutter_plugin_android_lifecycles (flutter/packages#7786)
2024-10-08 engine-flutter-autoroll@skia.org Manual roll Flutter from ec2e12b to 0917e9d (29 revisions) (flutter/packages#7816)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: interactive_media_ads Plugin for IMA SDK platform-android platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants