Skip to content

[pigeon] Use non-nullable generics in example app #7817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2024
Merged

[pigeon] Use non-nullable generics in example app #7817

merged 2 commits into from
Oct 8, 2024

Conversation

stuartmorgan-g
Copy link
Contributor

Now that Pigeon supports non-nullable generics, update the example app to show the much more likely use case of having non-nullable generics for collection types.

Part of flutter/flutter#155891

Pre-launch Checklist

@stuartmorgan-g
[pigeon] Use non-nullable generics in example app
b4972f6 
Now that Pigeon supports non-nullable generics, update the example app
to show the much more likely use case of having non-nullable generics
for collection types.

Part of flutter/flutter#155891
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g
Copy link
Contributor Author

This data is never used on the native side, so this is pretty much just changing generated code.

@stuartmorgan-g
Copy link
Contributor Author

test-exempt: code refactor with no semantic change

@stuartmorgan-g stuartmorgan-g mentioned this pull request Oct 8, 2024
Closed
@tarrinneal
Copy link
Contributor

Looks like you need to update the snippets

@LouiseHsu
Copy link
Contributor

LouiseHsu commented Oct 8, 2024 •
edited
Loading

This looks good, but is it okay if this waits for https://github.com/flutter/packages/pull/7812to merge, which would reland this revert #7810

@stuartmorgan-g
Copy link
Contributor Author

This looks good, but is it okay if this waits for https://github.com/flutter/packages/pull/7812to merge, which would reland this revert #7810

I assume this was intended for #7820? This one won't impact that PR.

@LouiseHsu
Copy link
Contributor

This looks good, but is it okay if this waits for https://github.com/flutter/packages/pull/7812to merge, which would reland this revert #7810

I assume this was intended for #7820? This one won't impact that PR.

Ah yes my bad, i got the prs confused

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Oct 8, 2024
@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Oct 8, 2024 •
edited
Loading

Override changelog: these are unpublished example files the failure is a repo tooling false positive (the tooling only flagged CHANGELOG, which is intended to err on the side of requiring an override, I just misread the log).

@stuartmorgan-g stuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App and removed override: no versioning needed Override the check requiring version bumps for most changes labels Oct 8, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Oct 8, 2024

auto label is removed for flutter/packages/7817, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2024
@auto-submit auto-submit bot merged commit 6125156 into flutter:main Oct 8, 2024
76 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 9, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 9, 2024
@engine-flutter-autoroll
612515613 [pigeon] Use non-nullable generics in example app (flutter/…
905fe7a 
…packages#7817)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 9, 2024
@engine-flutter-autoroll
Roll Packages from 8fbf4cda12e7 to 9d00fb1a8e50 (9 revisions) (#156477)
91df6ab 
flutter/packages@8fbf4cd...9d00fb1

2024-10-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for Android native `CompanionAd` (flutter/packages#7823)
2024-10-08 matanlurey@users.noreply.github.com Disable `SurfaceProducer.Callback` when the surface is disposed manually. (flutter/packages#7827)
2024-10-08 matanlurey@users.noreply.github.com Dispose the `ExoPlayer` before `SurfaceProducer`. (flutter/packages#7824)
2024-10-08 stuartmorgan@google.com [pigeon] Use non-nullable generics in example app (flutter/packages#7817)
2024-10-08 43054281+camsim99@users.noreply.github.com Manually Roll Flutter (stable) from 4cf269e to 2663184 (5 revisions) (flutter/packages#7819)
2024-10-08 stuartmorgan@google.com [camera] Update iOS Pigeon for non-nullable generics (flutter/packages#7787)
2024-10-08 stuartmorgan@google.com [in_app_purchase] Update Android Pigeon for non-nullable generics (flutter/packages#7788)
2024-10-08 jessiewong401@gmail.com [WIP] Updated applying gradle plugin for flutter_plugin_android_lifecycles (flutter/packages#7786)
2024-10-08 engine-flutter-autoroll@skia.org Manual roll Flutter from ec2e12b to 0917e9d (29 revisions) (flutter/packages#7816)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@stuartmorgan-g stuartmorgan-g deleted the non-null-pigeon-example branch October 9, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: pigeon platform-android platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartmorgan-g @tarrinneal @LouiseHsu