Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[camera_windows] Set device media type for video preview explicitly #7447

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dasyad00
Copy link

@dasyad00 dasyad00 commented Aug 19, 2024

Fixes preview aspect ratio on Windows on some webcams (See flutter/flutter#122966).

Before (main branch 7c1a05c):

image

After:

image

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@dasyad00 dasyad00 force-pushed the fix/camera_windows/black_bars branch from 0cf1e06 to 6dd71c9 Compare August 19, 2024 18:18
@dasyad00 dasyad00 marked this pull request as ready for review August 19, 2024 18:19
@stuartmorgan
Copy link
Contributor

Thanks for the contribution! This will need a test, per the PR checklist, before it can be reviewed.

@dasyad00
Copy link
Author

Since the bug arose due to a missing function call to Microsoft's Media Foundation API, the only test I can reasonably add is to verify the function is now called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants