Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 72356fda4684
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 26e123a6ce03
Choose a head ref
  • 19 commits
  • 103 files changed
  • 11 contributors

Commits on Nov 8, 2024

  1. [tools] Format Dart per-package (#8043)

    Instead of running Dart formatting on the whole repo at once, run it per
    package, from the package's directory. This is slower, but necessary
    since the new formatter behaves differently depending on the package's
    min SDK version.
    stuartmorgan authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    94d13ae View commit details
    Browse the repository at this point in the history
  2. [vector_graphics_compiler] fix-null-exception (#8006)

    The following SVG throw an exception (when using flutter_svg) : https://sweden.a.bigcontent.io/v1/static/10000199.
    
    This SVG contain an empty tag : <polygon xmlns="http://www.w3.org/2000/svg" fill="#0a287d" points="" id="polygon7"/> which lead to the issue.
    
    This PR check if path is null to avoid the issue.
    
    PR from dnfield/vector_graphics#254
    EArminjon authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    dcbac07 View commit details
    Browse the repository at this point in the history
  3. Group dependabot github-action update PRs, delete dead docker updates (

    …#8044)
    
    Dependabot now supports [grouping dependencies](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups) into one PR instead of one per dependency.
    
    Group github-action updates into one PR. Make github-actions update weekly instead of daily. Remove docker since it was removed in #4822
    
    This means a PR like #7813 will instead be grouped into one.
    Here's an example of what that will look like: kubernetes-sigs/cluster-api#11347
    
    __________
    
    <img width="400" alt="Screenshot 2024-11-08 at 11 08 52�AM" src="https://github.com/user-attachments/assets/eebedf69-3fae-409b-9c88-c3afc8036c52">
    
    __________
    
    https://github.com/kubernetes-sigs/cluster-api/blob/e13abeaed2bd3d7b04abd9c9823e2f4185fa6599/.github/dependabot.yaml#L10-L12
    
    I also updated the reviewers to stop the "One or more of the users or teams you specified is not a collaborator" [error](#7813 (comment)).
    
    Part of flutter/flutter#148098
    jmagman authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    036d1bd View commit details
    Browse the repository at this point in the history
  4. [animations] Remove .flutter-plugins reference from example app (#8002

    )
    
    Removes `.flutter-plugins` reference from example by (1) deleting the `packages/animations/example/android` directory, (2) running (in the `packages/animations` directory)
    
    ```
    flutter create example --platforms android -a kotlin --org "dev.flutter.packages.animations"
    ```
    and then (3) manually made the following changes:
    
    - Added back `packages/animations/example/android/.pluginToolsConfig.yaml` (removed by command)
    - Updated the Gradle version from 8.7 to 8.3 (downgraded by command)
    - Deleted  `example/analysis_options.yaml` (added by command)
    - Deleted `example/test/` (added by command)
    - Added back artifact hub
    - Removed template TODOs
    - Bumped Kotlin Gradle version to 1.9.0
    - Bumped AGP version from 8.1.0 to 8.5.1.
    
    Part of flutter/flutter#157660.
    camsim99 authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    a3ea39d View commit details
    Browse the repository at this point in the history
  5. Use dependabot multi-directory configuration for Android example grad…

    …le updates (#8036)
    
    [Multi-directory config](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#configuration-options-for-the-dependabotyml-file) allows duplicated dependabot configs can be removed in favor of one that specifies multiple directories.  Update the Android example apps so they can be updated all at once.
    
    Also updated the dependabot CI command to look for either `directory` or `directories` key.
    
    Part of flutter/flutter#148098
    jmagman authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2eedd7d View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. [shared_preferences] Fix confusing language in README (#8049)

    One use of "class" instead of "plugin" to refer to the `SharedPreferences` class specifically slipped through review. This updates it to make it clear that it's talking about a specific class, not the plugin.
    
    Also updates the `setPrefix:` doc comment to clarify that it only applies to that class, now that the addition of other classes to the API surface has made that ambiguous.
    
    Fixes flutter/flutter#158404
    stuartmorgan authored Nov 9, 2024
    Configuration menu
    Copy the full SHA
    a9b7140 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. [file_selector] Fix Linux cancel regression (#8051)

    Fixes a regression introduced during the Pigeon conversion where canceling a dialog would fail assertions due to accidentally returning a null list instead of an empty list.
    
    Fixes flutter/flutter#158430
    stuartmorgan authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d681e4e View commit details
    Browse the repository at this point in the history
  2. [tools] Run pub get before format (#8052)

    The new Dart formatter needs to know the Dart language version of the
    code it is formatting, and it reads that from a file in `.dart_tool`,
    not `pubspec.yaml` directly. To avoid it failing to determine the
    version and assuming the latest (which will almost always be wrong in
    this repo):
    - Adds a step to the `format` repo command to ensure that `pub get`
    appears to have been run, and runs it if not, and
    - To avoid `pub get` running in `format` in CI, adds a deps-fetching
    step to the `repo_checks` task, as we have in other tasks that need to
    `pub get`.
    
    This should unblock the roll.
    stuartmorgan authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    df0f423 View commit details
    Browse the repository at this point in the history
  3. Use dependabot multi-directory configuration for Android package upda…

    …tes (#8048)
    
    Follow up to #8036 (comment).
    
    [Multi-directory config](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#directories) allows duplicated dependabot configs can be removed in favor of one that specifies multiple directories.  Update Android packages so the same gradle dependencies can be updated all at once across packages.
    
    > The directories option in the dependabot.yml file allows you to apply Dependabot updates to multiple directories at the same time.
    
    It's unclear whether this is a good idea.
    > I'm a bit skeptical that grouping all the non-example ones together will be easier in practice, since usually some plugins are fine and some need changes, but I know the current system has some issues too.
    
    #8036 (review)
    
    The consensus seems to be we should try it, and revert or adjust if it makes the current system worse.
    
    Part of flutter/flutter#148098
    jmagman authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3a9226a View commit details
    Browse the repository at this point in the history
  4. Roll Flutter from 73546b3b71a7 to c8510f29ccc2 (30 revisions) (#8042)

    flutter/flutter@73546b3...c8510f2
    
    2024-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 44d788f4651b to a08bd5a07c2a (3 revisions) (flutter/flutter#158375)
    2024-11-08 tessertaha@gmail.com Add ability to override `NavigationDestination.label` padding for `NavigationBar` (flutter/flutter#158260)
    2024-11-08 stuartmorgan@google.com Add flutter/package code generation instructions (flutter/flutter#158326)
    2024-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8e19915c19fc to 44d788f4651b (3 revisions) (flutter/flutter#158362)
    2024-11-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from bcb281cde579 to 8e19915c19fc (4 revisions) (flutter/flutter#158354)
    2024-11-07 rmolivares@renzo-olivares.dev Make `_SelectableRegionSelectionContainerDelegate` public (flutter/flutter#147080)
    2024-11-07 jason-simmons@users.noreply.github.com Manual roll Flutter Engine from 371c86fb6b49 to bcb281cde579 (flutter/flutter#158346)
    2024-11-07 katelovett@google.com Add clarification on review timelines in PR template (flutter/flutter#158345)
    2024-11-07 bkonyi@google.com Increase Java heap limit to 8GB for plugin integration tests using deferred components (flutter/flutter#158330)
    2024-11-07 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#158337)
    2024-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from ac50b20ae5c9 to 371c86fb6b49 (5 revisions) (flutter/flutter#158336)
    2024-11-07 matanlurey@users.noreply.github.com Fix a breakage caused by the test being unskipped. (flutter/flutter#158335)
    2024-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8a963cfc134c to ac50b20ae5c9 (1 revision) (flutter/flutter#158308)
    2024-11-07 matanlurey@users.noreply.github.com `Plugin.isDevDependency` if exclusively in `dev_dependencies` (flutter/flutter#157462)
    2024-11-07 stuartmorgan@google.com Add recently imported packages to issue template (flutter/flutter#158324)
    2024-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 076688d95818 to 8a963cfc134c (1 revision) (flutter/flutter#158304)
    2024-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 94dac953a95f to 076688d95818 (2 revisions) (flutter/flutter#158303)
    2024-11-07 polinach@google.com Make leak tracking bots blocking. (flutter/flutter#157866)
    2024-11-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b36ca3319825 to 94dac953a95f (1 revision) (flutter/flutter#158297)
    2024-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 58ac1dadd69d to b36ca3319825 (9 revisions) (flutter/flutter#158295)
    2024-11-06 5593189+p-salmon@users.noreply.github.com Added cusor control properties to CupertinoSearchTextField and tests (flutter/flutter#158240)
    2024-11-06 bkonyi@google.com Fix flakiness in hot_reload_test.dart (flutter/flutter#158271)
    2024-11-06 34871572+gmackall@users.noreply.github.com Fix use of deprecated `buildDir` in Android templates/tests/examples (flutter/flutter#157560)
    2024-11-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from f03f11300a9d to 58ac1dadd69d (5 revisions) (flutter/flutter#158283)
    2024-11-06 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#158281)
    2024-11-06 magder@google.com Delete firebase_android_embedding_v2_smoke_test (flutter/flutter#158223)
    2024-11-06 yjbanov@google.com [web] fix --ab option for web benchmarks (flutter/flutter#154574)
    2024-11-06 47866232+chunhtai@users.noreply.github.com excluding website-cms from critical pr triage (flutter/flutter#158220)
    2024-11-06 32538273+ValentinVignal@users.noreply.github.com Add test for `image.frame_builder.0.dart` (flutter/flutter#158247)
    2024-11-06 engine-flutter-autoroll@skia.org Roll Packages from 7219431 to bb5a258 (6 revisions) (flutter/flutter#158267)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages
    Please CC camillesimon@google.com,stuartmorgan@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3663103 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. [pigeon] Make Linux type declarations public (#8040)

    Moves codec and HostAPI class declarations to the header to work around a glib bug. We could instead add an unnecessary call to the type check method, but we will need the codec to be public eventually anyway, and HostApi is conceptually a public class (it just isn't strictly necessary to declare it in the header due to the way abstract interfaces work in gobject) so may as well be declared publicly.
    
    Part of flutter/flutter#153083
    stuartmorgan authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    5e90ce2 View commit details
    Browse the repository at this point in the history
  2. [go_router] Add support for preloading branches of StatefulShellRoute…

    … (revised solution) (#6467)
    
    Adds support for preloading branches in a `StatefulShellRoute`. This functionality was initially part of an early implementation of #2650, however it was decided to implement this in a separate PR. The current implementation is a rewrite of the original implementation to better fit the final version of `StatefulShellRoute` (and go_router in general). 
    
    **NOTE**: this is a revised version of the initial solution (see #4251), containing a substantially simpler implementation made possible thanks to recent refactoring in go_router.
    
    This fixes issue flutter/flutter#127804.
    tolo authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9c294ef View commit details
    Browse the repository at this point in the history
  3. [url_launcher] Update Pigeon version for Linux (#8065)

    Updates to the latest version of Pigeon, picking up the change to make the declarations of some classes public rather than in the implementation file.
    
    Fixes flutter/flutter#153083
    stuartmorgan authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    53c1ff2 View commit details
    Browse the repository at this point in the history
  4. [ci] Remove web renderer option from tools. (#8055)

    Removes the `--web-renderer` option from the "drive examples" and "dart test" commands.
    
    Fixes flutter/flutter#151869
    ditman authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    4a7b385 View commit details
    Browse the repository at this point in the history
  5. [various] Clean up contributing guides (#8032)

    Several packages had documentation about how to use Pigeon or Mockito generation; this made sense when those were rare, but they are both now extremely common in our packages. Instead,
    flutter/flutter#158326 adds this information to the general documentation for contribuing to flutter/packages, so it no longer needs to be in (a random subset of) specific packages.
    
    This also removes Contributing sections from several READMEs, as READMEs should be client-focused rather than developer-focused, and puts content in CONTRIBUTING.md where needed.
    stuartmorgan authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1d14251 View commit details
    Browse the repository at this point in the history
  6. [in_app_purchase] Add expiration date to Transaction (#8030)

    Closes flutter/flutter#158226
    
    Exposes the Transaction's expiration date, so this information can be used on the dart side.
    feinstein authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c77ab99 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. [vector_graphics_compiler] fix a renamed method parameter lint (#8070)

    An upcoming fix to `avoid_renaming_method_parameters` will flag this
    rename.
    
    (I updated the base class since that seems more correct.)
    
    For references, here's the fix in flight:
    https://dart-review.googlesource.com/c/sdk/+/394662
    
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] page, which explains my
    responsibilities.
    - [x] I read and followed the [relevant style guides] and ran the
    auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
    repo does use `dart format`.)
    - [x] I signed the [CLA].
    - [ ] The title of the PR starts with the name of the package surrounded
    by square brackets, e.g. `[shared_preferences]`
    - [ ] I [linked to at least one issue that this PR fixes] in the
    description above.
    - [ ] I updated `pubspec.yaml` with an appropriate new version according
    to the [pub versioning philosophy], or this PR is [exempt from version
    changes].
    - [ ] I updated `CHANGELOG.md` to add a description of the change,
    [following repository CHANGELOG style], or this PR is [exempt from
    CHANGELOG changes].
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
    [relevant style guides]:
    https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
    [CLA]: https://cla.developers.google.com/
    [Discord]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
    [linked to at least one issue that this PR fixes]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
    [pub versioning philosophy]: https://dart.dev/tools/pub/versioning
    [exempt from version changes]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version
    [following repository CHANGELOG style]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
    [exempt from CHANGELOG changes]:
    https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog
    [test-exempt]:
    https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
    pq authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e547e7a View commit details
    Browse the repository at this point in the history
  2. [go_router] Add support for relative routes (#6825)

    Add supports for relative routes by allowing going to a path relatively, like go('./$path')
    
    This PR doesn't fully resolve any issue, but it's mandatory to further add examples & tests for `TypedRelativeGoRoute` (see [#7174](#6823)), which will resolves [#108177](flutter/flutter#108177)
    ThangVuNguyenViet authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    67d8b50 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    26e123a View commit details
    Browse the repository at this point in the history
Loading