Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_adsense] AdSense plugin for Flutter Web #6871

Draft
wants to merge 62 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
ddb2de6
Initial version of AdSense plugin for Flutter Web
sokoloff06 Jun 5, 2024
968dcdb
Merge branch 'flutter:main' into main
sokoloff06 Jun 5, 2024
3c99bae
Merge branch 'flutter:main' into main
sokoloff06 Jul 21, 2024
c37d644
WIP: apply flutter_packages analysis_options.yaml and fixing warnings
sokoloff06 Jul 21, 2024
dfae8ee
Merge remote-tracking branch 'origin/main'
sokoloff06 Jul 21, 2024
15826c0
remove local analysis_options.yaml
sokoloff06 Jul 21, 2024
6050087
Update README.md, pubspec.yaml, work on example and linter warnings
sokoloff06 Jul 25, 2024
25158d3
Update public API, add example, update README.md, add more docs and s…
sokoloff06 Jul 27, 2024
91ae43f
Update public API, add example, update README.md, add more docs and s…
sokoloff06 Jul 27, 2024
4308c93
Merge remote-tracking branch 'origin/main'
sokoloff06 Jul 27, 2024
52fb128
Merge remote-tracking branch 'origin/main'
sokoloff06 Jul 27, 2024
a562233
Merge remote-tracking branch 'origin/main'
sokoloff06 Jul 27, 2024
500483d
Fix analyzer warnings
sokoloff06 Jul 27, 2024
65c61ab
Updated README.md
sokoloff06 Jul 27, 2024
065e6fe
Add documentation, copyright, initial tests, update README.md
sokoloff06 Aug 4, 2024
b99f4f7
Fix linter error
sokoloff06 Aug 4, 2024
2c7db93
Make plugin closer to publishable state: update copyright, commit mis…
sokoloff06 Aug 4, 2024
1697032
Rename adView to adUnit, fix deps and update README.md
sokoloff06 Aug 4, 2024
875f621
Merge branch 'main' into main
sokoloff06 Aug 4, 2024
5773e5d
Refactoring + unit tests
sokoloff06 Aug 11, 2024
537d611
Merge remote-tracking branch 'origin/main'
sokoloff06 Aug 11, 2024
f105166
Refactoring + unit tests
sokoloff06 Aug 11, 2024
7d3b9c2
Upgrade dart SDK
sokoloff06 Aug 11, 2024
de1fe7c
Upgrade package:web and dart
sokoloff06 Aug 11, 2024
458cb4e
Add integration test
sokoloff06 Sep 15, 2024
ffab481
Clarify 403 error in README.md
sokoloff06 Sep 15, 2024
257007f
Rename ad_unit_widget.dart and solve dart analysis errors
sokoloff06 Sep 27, 2024
7701a7c
Merge branch 'main' into main
sokoloff06 Sep 27, 2024
172dd00
Add styling property for adUnit CSS customization
sokoloff06 Oct 12, 2024
c427a8a
Merge remote-tracking branch 'origin/main'
sokoloff06 Oct 12, 2024
689b1a6
Merge branch 'main' into main
sokoloff06 Oct 12, 2024
215da90
Code format
sokoloff06 Oct 12, 2024
3232f0e
Fix repo rules
sokoloff06 Oct 12, 2024
d59f7b7
Fix repo rules
sokoloff06 Oct 12, 2024
98b0845
Update min Dart version and readme links
sokoloff06 Oct 12, 2024
0232565
Update min SDK versions for dependencies compatibility
sokoloff06 Oct 12, 2024
f2b9c06
Fix typo
sokoloff06 Oct 16, 2024
db13a98
Revert README.md
sokoloff06 Oct 28, 2024
51e2042
Update README.md
sokoloff06 Oct 28, 2024
c57e03f
Merge branch 'main' into main
sokoloff06 Oct 28, 2024
e6842f2
Update README.md, rename class Adsense into AdSense
sokoloff06 Oct 28, 2024
913f347
Update packages/google_adsense/example/pubspec.yaml
sokoloff06 Oct 28, 2024
9ba0ba5
Use instance property to access AdSense singleton instance
sokoloff06 Oct 28, 2024
eb20328
Merge remote-tracking branch 'sokoloff06/main' into fork/sokoloff06/main
sokoloff06 Oct 28, 2024
2a8a998
Add explanation about local DNS records for testing environment
sokoloff06 Oct 29, 2024
1c29983
Use strong String type for additionalParams argument values
sokoloff06 Oct 29, 2024
d07ea36
Remove as JS* casts, change isAdTest default value, improve some docs…
sokoloff06 Oct 29, 2024
d48aa16
Remove as JS* casts, change isAdTest default value, improve some docs…
sokoloff06 Oct 29, 2024
094460b
Add screenshots to pubspec.yaml
sokoloff06 Oct 30, 2024
3f58513
Simplify ResizeObserver, define adsbygoogle JS variable
sokoloff06 Nov 3, 2024
988d3f7
Code cleanup
sokoloff06 Nov 3, 2024
6c244fd
Merge tests
sokoloff06 Nov 3, 2024
410a7eb
Tests cleanup
sokoloff06 Nov 3, 2024
dc78f2e
Provide adSense global variable for convenience
sokoloff06 Nov 3, 2024
12e657d
Remove adClient override logic,
sokoloff06 Nov 11, 2024
3a820bc
Update adUnit API with AdUnitConfiguration and named constructors for…
sokoloff06 Nov 12, 2024
1d288db
Remove test_ad.html, format code
sokoloff06 Nov 12, 2024
d214fc0
Merge branch 'main' into main
sokoloff06 Nov 12, 2024
3fda3da
Ignore avoid_print in test, remove redundant arguments
sokoloff06 Nov 12, 2024
0258b86
use testWidgets in integration tests
sokoloff06 Nov 12, 2024
b9f61b8
Fix adUnit returns Widget type test
sokoloff06 Nov 12, 2024
c509169
Update README.md and add LICENSE
sokoloff06 Nov 12, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ packages/flutter_migrate/** @stuartmorgan
packages/flutter_template_images/** @stuartmorgan
packages/go_router/** @chunhtai
packages/go_router_builder/** @chunhtai
packages/google_adsense/** @sokoloff06
packages/google_identity_services_web/** @ditman
packages/google_maps_flutter/** @stuartmorgan
packages/google_sign_in/** @stuartmorgan
Expand Down
87 changes: 44 additions & 43 deletions README.md

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions packages/google_adsense/AUTHORS
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Below is a list of people and organizations that have contributed
# to the Flutter project. Names should be added to the list like so:
#
# Name/Organization <email address>

Google Inc.
The Chromium Authors
3 changes: 3 additions & 0 deletions packages/google_adsense/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 0.0.1
sokoloff06 marked this conversation as resolved.
Show resolved Hide resolved

* Initial release.
25 changes: 25 additions & 0 deletions packages/google_adsense/LICENSE
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
Copyright 2013 The Flutter Authors. All rights reserved.

Redistribution and use in source and binary forms, with or without modification,
are permitted provided that the following conditions are met:

* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the following
disclaimer in the documentation and/or other materials provided
with the distribution.
* Neither the name of Google Inc. nor the names of its
contributors may be used to endorse or promote products derived
from this software without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
60 changes: 60 additions & 0 deletions packages/google_adsense/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
# google_adsense
[Google AdSense](https://adsense.google.com/intl/en_us/start/) plugin for Flutter Web

Generally integration with AdSense requires:

1. Adding an [AdSense code](https://support.google.com/adsense/answer/9274634?hl=en&ref_topic=28893&sjid=9002959242386336076-EU) usually in between the `<head></head>` tag to connect your site with AdSense account. Allows using **Auto ads**
2. Adding [ad unit code](https://support.google.com/adsense/answer/9274025?sjid=9002959242386336076-EU) in between the `<body><body/>` tags of your pages where you want ad to appear. Ad unit code snippet is unique per **ad unit** that you need to create in your AdSense account first. You might have several ad units added to your website
sokoloff06 marked this conversation as resolved.
Show resolved Hide resolved

Since Flutter apps are not rendered as traditional HTML pages and there is no easy way to access final DOM tree from Dart, this plugin provides an `AdUnitWidget` that you can configure and place in the desired location in your app UI


## Installation
run `flutter pub add google_adsense`

## Usage
#### Initialize AdSense
Before displaying ads, initialize the AdSense with your ad client ID.
sokoloff06 marked this conversation as resolved.
Show resolved Hide resolved
<?code-excerpt "example/lib/main.dart (init)"?>
sokoloff06 marked this conversation as resolved.
Show resolved Hide resolved
```dart
import 'package:google_adsense/google_adsense.dart';

void main() {
Adsense().initialize('your_ad_client_id');
runApp(const MyApp());
}

```
#### Display AdUnitWidget
<?code-excerpt "example/lib/main.dart (adUnit)"?>
```dart
Adsense().adUnit(
sokoloff06 marked this conversation as resolved.
Show resolved Hide resolved
adSlot: 'your_ad_slot_id',
isAdTest: true,
adUnitParams: <String, dynamic>{
AdUnitParams.AD_FORMAT: 'auto',
AdUnitParams.FULL_WIDTH_RESPONSIVE: true,
},
sokoloff06 marked this conversation as resolved.
Show resolved Hide resolved
cssText:
'border: 5px solid red; display: block; padding: 20px'),
```
## Testing and common errors

### Failed to load resource: the server responded with a status of 400
Make sure to replace `your_ad_client_id` and `your_ad_slot_id` with the relevant values

### Failed to load resource: the server responded with a status of 403
1. When happening in **testing/staging** environment it is likely related to the fact that ads are only filled when requested from an authorized domain. If you are testing locally, you can specify additional run arguments in IDE my editing `Run/Debug Configuration` or by passing them directly to `flutter run` command:
sokoloff06 marked this conversation as resolved.
Show resolved Hide resolved
`--web-port=8080`
`--web-hostname=your-domain.com`
sokoloff06 marked this conversation as resolved.
Show resolved Hide resolved
2. When happening in **production** it might be that your domain was not yet approved or was disapproved. Login to your AdSense account to check your domain approval status

### Ad unfilled

There is no deterministic way to make sure your ads are 100% filled even when testing. Some of the way to increase the fill rate:


- Add AD_TEST parameter with value `true`
- Make sure AD_FORMAT is `auto` (default setting)
- Make sure FULL_WIDTH_RESPONSIVE is `true` (default setting)
sokoloff06 marked this conversation as resolved.
Show resolved Hide resolved
- Try resizing the window or making sure that adUnitWidget width is less than ~1300px
6 changes: 6 additions & 0 deletions packages/google_adsense/dart_test.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
## See https://github.com/dart-lang/test/blob/master/pkgs/test/doc/configuration.md#arguments
#override_platforms:
# chrome:
# settings:
# executable: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
# arguments: --no-sandbox
10 changes: 10 additions & 0 deletions packages/google_adsense/example/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# google_adsense_example

An example demonstrating google_adsense Flutter plugin usage

## Screenshots

![Screenshot of the test app showing an ad on mobile](../example/images/mobile_screenshot.png)
sokoloff06 marked this conversation as resolved.
Show resolved Hide resolved
![Screenshot of the test app showing an ad on desktop](../example/images/desktop_screenshot.jpg)


Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TO run the test:
// 1. Run chrome driver with --port=4444
// 2. Run the test from example folder with: flutter drive -d web-server --web-port 7357 --browser-name chrome --driver test_driver/integration_test.dart --target integration_test/ad_widget_rendering_test.dart

import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:google_adsense/google_adsense.dart';
import 'package:integration_test/integration_test.dart';
import 'package:web/web.dart' as web;

const String testClient = 'test_client';
const String testSlot = 'test_slot';

void main() async {
IntegrationTestWidgetsFlutterBinding.ensureInitialized();

setUp(() async {
Adsense.resetForTesting();
});

group('adWidget', () {
testWidgets('AdUnitWidget is created and rendered',
(WidgetTester tester) async {
// When
// TODO(sokoloff06): Mock server response as ./test_ad.html

Adsense().initialize(testClient);
final Widget adUnitWidget = Adsense().adUnit(adSlot: testSlot);
await tester.pumpWidget(adUnitWidget);
await tester.pumpWidget(
adUnitWidget); // TODO(sokoloff06): Why only works when pumping twice?
// Then
// Widget level
expect(find.byWidget(adUnitWidget), findsOneWidget);
expect(adUnitWidget, isA<AdUnitWidget>());

// DOM level
final web.HTMLElement? platformView =
web.document.querySelector('flt-platform-view') as web.HTMLElement?;
expect(platformView, isNotNull);
final web.HTMLElement ins =
platformView!.getElementsByTagName('ins').item(0)! as web.HTMLElement;
sokoloff06 marked this conversation as resolved.
Show resolved Hide resolved
expect(ins.style.display, 'block');

// TODO(sokoloff06): Validate response is rendered
});
});
}
Loading