[google_adsense] AdSense plugin for Flutter Web #6871
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
sokoloff06
changed the title
…sing files, remove extra deps etc...
Add proper js_interop for loading new ads
ditman
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Thanks for the code @sokoloff06!
I left a bunch of comments, but I think all should be easy to fix/actionable.
Do message me if you need any help with any of the fixes (esp. on the JS-interop stuff, that is in flux)!
remove extra line Co-authored-by: David Iglesias <ditman@gmail.com>
11 tasks
…, remove dynamic adUnitParams leftovers, run dart format
…, remove dynamic adUnitParams leftovers, run dart format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Adsense plugin should allow Flutter Web developers to integrate Adsense more easily and monetize web project.
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#40376
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.