[url_launcher] Android API 34 support #4660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equired by target api 34" (flutter#4027)" This reverts commit baeca88.
reidbaker
commented
Aug 7, 2023
packages/url_launcher/url_launcher_android/example/integration_test/url_launcher_test.dart
Outdated
Show resolved
Hide resolved
|
also fixes https://b.corp.google.com/issues/294558650 |
stuartmorgan-g
requested changes
Aug 8, 2023
| await Future<void>.delayed(const Duration(seconds: 3)); | ||
| await launcher.closeWebView(); | ||
| // Delay required to catch android side crashes in onDestroy | ||
| await Future<void>.delayed(const Duration(seconds: 3)); |
There was a problem hiding this comment.
I think we would need flutter/flutter#20034 to remove this; a TODO referencing that issue wouldn't hurt.
In the meantime, do we really need 3 seconds to reliably catch closing the page? That seems crazy long.
There was a problem hiding this comment.
3s was the shortest I could make it and have the test reliability catch a crash that can happen in onDestroy on my physical phone. I ended up verifying on an emulator and actually needed to bump the delay to 5s. 3 would not reliably catch the potential crash and 4s was flakey in catching the crash.
I think we need to wait the full 5s otherwise this test does not actually catch a regression in the code that was fixed.
packages/url_launcher/url_launcher_android/example/integration_test/url_launcher_test.dart
Outdated
Show resolved
Hide resolved
packages/url_launcher/url_launcher_android/example/integration_test/url_launcher_test.dart
Outdated
Show resolved
Hide resolved
…esting on emulators, update documentation with an explination of why the delay
stuartmorgan-g
approved these changes
Aug 9, 2023
packages/url_launcher/url_launcher_android/example/integration_test/url_launcher_test.dart
Outdated
Show resolved
Hide resolved
packages/url_launcher/url_launcher_android/example/integration_test/url_launcher_test.dart
Outdated
Show resolved
Hide resolved
reidbaker
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 9, 2023
flutter/packages@ac41376...881c1f5 2023-08-09 engine-flutter-autoroll@skia.org Roll Flutter from 436df69 to f4c25bb (28 revisions) (flutter/packages#4666) 2023-08-09 reidbaker@google.com [url_launcher] Android API 34 support (flutter/packages#4660) 2023-08-08 67326251+Franreno@users.noreply.github.com Migrating styleFrom API to new version. (flutter/packages#4540) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #flutter/flutter/issues/126460
Reland of #3973 which incorrectly used application context when registering and not when unregistering. This pr uses activity context for both which is aligned with what the behavior was before.
Tested with manual test and new integration test.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).