Skip to content

Migrating styleFrom API to new version. #4540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 8, 2023
Merged

Migrating styleFrom API to new version. #4540

merged 8 commits into from
Aug 8, 2023

Conversation

Franreno
Copy link
Contributor

Updates the styleFrom API to use backgroundColor and foregroundColor instead of deprecated methods (primary, onPrimary).

Fixes #105724

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

stuartmorgan-g
stuartmorgan-g requested changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this cleanup! Just a note of the CHANGELOG wording (which applies to all of them, so it may be easiest to git revert 1fe1ba4a and then re-run update-release-info.

@Hixie
Copy link
Contributor

Hixie commented Jul 21, 2023

test-exempt: code refactor with no semantic change

@Franreno
Copy link
Contributor Author

Thanks for all the suggestions, @stuartmorgan!
I have re-run the changelog command and pushed another commit with the changes you suggested.
Let me know if I did something wrong and need changes!

@Franreno Franreno requested a review from stuartmorgan-g July 21, 2023 17:02
stuartmorgan-g
stuartmorgan-g approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bparrishMines or @tarrinneal could you do the second review here since it's repo-wide?

@tarrinneal
Copy link
Contributor

All looks good to me, if you could manage the changelog conflicts, we can land this.

@stuartmorgan-g
Copy link
Contributor

I've resolved the conflicts (I just wanted to wait for the second approval to do so in case others showed up in the meantime).

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2023
@tarrinneal tarrinneal added emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. and removed emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. labels Aug 8, 2023
@auto-submit auto-submit bot merged commit 34683ac into flutter:main Aug 8, 2023
@tarrinneal
Copy link
Contributor

override to land due to broken test for failures on main

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2023
@engine-flutter-autoroll
34683ac Migrating styleFrom API to new version. (flutter/packages#4540)
86ec5fe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2023
@engine-flutter-autoroll
34683ac Migrating styleFrom API to new version. (flutter/packages#4540)
7ef79b9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2023
@engine-flutter-autoroll
34683ac Migrating styleFrom API to new version. (flutter/packages#4540)
a44e485
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 9, 2023
@engine-flutter-autoroll
Roll Packages from ac41376 to 881c1f5 (3 revisions) (#132234)
c495496 
flutter/packages@ac41376...881c1f5

2023-08-09 engine-flutter-autoroll@skia.org Roll Flutter from 436df69 to f4c25bb (28 revisions) (flutter/packages#4666)
2023-08-09 reidbaker@google.com [url_launcher] Android API 34 support (flutter/packages#4660)
2023-08-08 67326251+Franreno@users.noreply.github.com Migrating styleFrom API to new version. (flutter/packages#4540)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

@cbracken cbracken Awaiting requested review from cbracken cbracken is a code owner

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin hellohuanlin is a code owner

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. p: camera p: file_selector p: in_app_purchase platform-android platform-ios platform-linux platform-macos platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate plugins to new styleFrom button API
4 participants
@Franreno @Hixie @tarrinneal @stuartmorgan-g