[ci] Add emulator tests on older Android version #4616
Conversation
stuartmorgan-g
changed the title
script/configs/exclude_integration_android_legacy_emulator.yaml
Outdated
Show resolved
Hide resolved
.ci.yaml
Outdated
| package_sharding: "--shardIndex 3 --shardCount 6" | ||
| dependencies: >- | ||
| [ | ||
| {"dependency": "android_virtual_device", "version": "22"} |
There was a problem hiding this comment.
Out of scope for this pr but I wish we could use variables for these shards since they cant actually have different dependencies.
There was a problem hiding this comment.
I could make a new config for legacy emulator Android tests, but without a way to have one platform_properties entry inherit from another one that sort of just moves the problem (since I'd have to instead duplicate all the core Android dependencies, which can't really be different either). Would you prefer that? I can see an argument for it being less error-prone.
There was a problem hiding this comment.
I think it is out of scope for this change but anyplace we can make it clear in code that dependencies that have to be the same are the same I think it is a win for clarity and maintainability.
There was a problem hiding this comment.
Since this is a whole new set of shards with configs, it seems in scope to have it start the way you'd prefer it; I'll leave the existing ones alone for now though (especially so I don't mess up Camille's WIP PR).
There was a problem hiding this comment.
Let me know what you think of this updated version :)
.ci.yaml
Outdated
| package_sharding: "--shardIndex 3 --shardCount 6" | ||
| dependencies: >- | ||
| [ | ||
| {"dependency": "android_virtual_device", "version": "22"} |
There was a problem hiding this comment.
I think it is out of scope for this change but anyplace we can make it clear in code that dependencies that have to be the same are the same I think it is a win for clarity and maintainability.
stuartmorgan-g
added
the
autosubmit
flutter/packages@09c6b11...be915be 2023-10-20 737941+loic-sharma@users.noreply.github.com [ci] Finalize migration to x64 specific Windows platform (flutter/packages#5174) 2023-10-19 15619084+vashworth@users.noreply.github.com [image_picker_ios] Update UITests for Xcode 15/iOS 17 (flutter/packages#5176) 2023-10-19 stuartmorgan@google.com [ci] Add emulator tests on older Android version (flutter/packages#4616) 2023-10-19 engine-flutter-autoroll@skia.org Roll Flutter from 189196d to c2bd2c1 (11 revisions) (flutter/packages#5183) 2023-10-19 stuartmorgan@google.com [tool] Fix `filter-packages-to` when everything is changed (flutter/packages#5182) 2023-10-19 tarrinneal@gmail.com [pigeon] add flutter api protocol (flutter/packages#5181) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Adds new tasks to run integration tests on legacy Android emulators (API 22, since we don't currently have API 21 emulators available), so that we are getting more complete coverage of our supported OS versions.
For now, excludes several plugins with TODOs and issues filed, so that the suite can be brought online in parallel with investigation of those issues.
Most of flutter/flutter#130010