Skip to content

Fix stale ignore: prefer_const_constructors from flutter/packages #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5 changes: 5 additions & 0 deletions packages/flutter_adaptive_scaffold/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## NEXT

* Fixes stale ignore: prefer_const_constructors.
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.

## 0.1.4

* Use Material 3 NavigationBar instead of BottomNavigationBar
Expand Down
16 changes: 5 additions & 11 deletions packages/flutter_adaptive_scaffold/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -412,11 +412,9 @@ class _LargeComposeIcon extends StatelessWidget {
child: Column(children: <Widget>[
Container(
padding: const EdgeInsets.fromLTRB(6, 0, 0, 0),
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
child: Row(
child: const Row(
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: const <Widget>[
children: <Widget>[
Text(
'REPLY',
style: TextStyle(color: Colors.deepPurple, fontSize: 15),
Expand Down Expand Up @@ -444,14 +442,10 @@ class _LargeComposeIcon extends StatelessWidget {
),
width: 200,
height: 50,
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
child: Padding(
padding: const EdgeInsets.fromLTRB(16.0, 0, 0, 0),
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
child: const Padding(
padding: EdgeInsets.fromLTRB(16.0, 0, 0, 0),
child: Row(
children: const <Widget>[
children: <Widget>[
Icon(Icons.edit_outlined),
SizedBox(width: 20),
Center(child: Text('Compose')),
Expand Down
4 changes: 2 additions & 2 deletions packages/flutter_adaptive_scaffold/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ publish_to: 'none'
version: 0.0.1

environment:
sdk: ">=2.18.0 <4.0.0"
flutter: ">=3.3.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

dependencies:
flutter:
Expand Down
4 changes: 2 additions & 2 deletions packages/flutter_adaptive_scaffold/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
repository: https://github.com/flutter/packages/tree/main/packages/flutter_adaptive_scaffold

environment:
sdk: ">=2.18.0 <4.0.0"
flutter: ">=3.3.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

dependencies:
flutter:
Expand Down
5 changes: 5 additions & 0 deletions packages/flutter_markdown/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## NEXT

* Fixes stale ignore: prefer_const_constructors.
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.

## 0.6.15

* Fixes unawaited_futures violations.
Expand Down
4 changes: 2 additions & 2 deletions packages/flutter_markdown/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 0.6.15

environment:
sdk: ">=2.18.0 <4.0.0"
flutter: ">=3.3.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

dependencies:
flutter:
Expand Down
12 changes: 4 additions & 8 deletions packages/flutter_markdown/test/list_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,8 @@ void defineTests() {

await tester.pumpWidget(
boilerplate(
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
Column(
children: const <Widget>[
const Column(
children: <Widget>[
MarkdownBody(fitContent: false, data: data),
],
),
Expand All @@ -219,10 +217,8 @@ void defineTests() {

await tester.pumpWidget(
boilerplate(
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
Column(
children: const <Widget>[
const Column(
children: <Widget>[
MarkdownBody(data: data),
],
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@ void defineTests() {
'Then it wraps its content',
(WidgetTester tester) async {
await tester.pumpWidget(boilerplate(
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
Stack(
children: const <Widget>[
const Stack(
children: <Widget>[
Text('shrinkWrap=true'),
Align(
alignment: Alignment.bottomCenter,
Expand Down Expand Up @@ -48,10 +46,8 @@ void defineTests() {
'Then it expands to the maximum allowed height',
(WidgetTester tester) async {
await tester.pumpWidget(boilerplate(
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
Stack(
children: const <Widget>[
const Stack(
children: <Widget>[
Text('shrinkWrap=false test'),
Align(
alignment: Alignment.bottomCenter,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## NEXT

* Fixes stale ignore: prefer_const_constructors.
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.

## 2.3.0

* Endorses [`google_maps_flutter_web`](https://pub.dev/packages/google_maps_flutter_web)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ description: Demonstrates how to use the google_maps_flutter plugin.
publish_to: none

environment:
sdk: ">=2.18.0 <4.0.0"
flutter: ">=3.3.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

dependencies:
cupertino_icons: ^1.0.5
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 2.3.0

environment:
sdk: ">=2.18.0 <4.0.0"
flutter: ">=3.3.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

flutter:
plugin:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,10 @@ void main() {
) async {
// Inject two map widgets...
await tester.pumpWidget(
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
Directionality(
const Directionality(
textDirection: TextDirection.ltr,
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
child: Column(
children: const <Widget>[
children: <Widget>[
GoogleMap(
initialCameraPosition: CameraPosition(
target: LatLng(43.362, -5.849),
Expand Down
3 changes: 2 additions & 1 deletion packages/local_auth/local_auth/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
## NEXT

* Updates minimum Flutter version to 3.3.
* Aligns Dart and Flutter SDK constraints.
* Fixes stale ignore: prefer_const_constructors.
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.

## 2.1.6

Expand Down
12 changes: 4 additions & 8 deletions packages/local_auth/local_auth/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -183,11 +183,9 @@ class _MyAppState extends State<MyApp> {
if (_isAuthenticating)
ElevatedButton(
onPressed: _cancelAuthentication,
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
child: Row(
child: const Row(
mainAxisSize: MainAxisSize.min,
children: const <Widget>[
children: <Widget>[
Text('Cancel Authentication'),
Icon(Icons.cancel),
],
Expand All @@ -198,11 +196,9 @@ class _MyAppState extends State<MyApp> {
children: <Widget>[
ElevatedButton(
onPressed: _authenticate,
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
child: Row(
child: const Row(
mainAxisSize: MainAxisSize.min,
children: const <Widget>[
children: <Widget>[
Text('Authenticate'),
Icon(Icons.perm_device_information),
],
Expand Down
4 changes: 2 additions & 2 deletions packages/local_auth/local_auth/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ description: Demonstrates how to use the local_auth plugin.
publish_to: none

environment:
sdk: ">=2.18.0 <4.0.0"
flutter: ">=3.3.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

dependencies:
flutter:
Expand Down
4 changes: 2 additions & 2 deletions packages/local_auth/local_auth/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 2.1.6

environment:
sdk: ">=2.18.0 <4.0.0"
flutter: ">=3.3.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

flutter:
plugin:
Expand Down
5 changes: 5 additions & 0 deletions packages/local_auth/local_auth_android/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## NEXT

* Fixes stale ignore: prefer_const_constructors.
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.

## 1.0.31

* Updates androidx.fragment version to 1.5.7.
Expand Down
12 changes: 4 additions & 8 deletions packages/local_auth/local_auth_android/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,9 @@ class _MyAppState extends State<MyApp> {
if (_isAuthenticating)
ElevatedButton(
onPressed: _cancelAuthentication,
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
child: Row(
child: const Row(
mainAxisSize: MainAxisSize.min,
children: const <Widget>[
children: <Widget>[
Text('Cancel Authentication'),
Icon(Icons.cancel),
],
Expand All @@ -203,11 +201,9 @@ class _MyAppState extends State<MyApp> {
children: <Widget>[
ElevatedButton(
onPressed: _authenticate,
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
child: Row(
child: const Row(
mainAxisSize: MainAxisSize.min,
children: const <Widget>[
children: <Widget>[
Text('Authenticate'),
Icon(Icons.perm_device_information),
],
Expand Down
4 changes: 2 additions & 2 deletions packages/local_auth/local_auth_android/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ description: Demonstrates how to use the local_auth_android plugin.
publish_to: none

environment:
sdk: ">=2.18.0 <4.0.0"
flutter: ">=3.3.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

dependencies:
flutter:
Expand Down
4 changes: 2 additions & 2 deletions packages/local_auth/local_auth_android/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 1.0.31

environment:
sdk: ">=2.18.0 <4.0.0"
flutter: ">=3.3.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

flutter:
plugin:
Expand Down
5 changes: 5 additions & 0 deletions packages/local_auth/local_auth_ios/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## NEXT

* Fixes stale ignore: prefer_const_constructors.
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.

## 1.1.3

* Migrates internal implementation to Pigeon.
Expand Down
12 changes: 4 additions & 8 deletions packages/local_auth/local_auth_ios/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -187,11 +187,9 @@ class _MyAppState extends State<MyApp> {
if (_isAuthenticating)
ElevatedButton(
onPressed: _cancelAuthentication,
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
child: Row(
child: const Row(
mainAxisSize: MainAxisSize.min,
children: const <Widget>[
children: <Widget>[
Text('Cancel Authentication'),
Icon(Icons.cancel),
],
Expand All @@ -202,11 +200,9 @@ class _MyAppState extends State<MyApp> {
children: <Widget>[
ElevatedButton(
onPressed: _authenticate,
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
child: Row(
child: const Row(
mainAxisSize: MainAxisSize.min,
children: const <Widget>[
children: <Widget>[
Text('Authenticate'),
Icon(Icons.perm_device_information),
],
Expand Down
4 changes: 2 additions & 2 deletions packages/local_auth/local_auth_ios/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ description: Demonstrates how to use the local_auth_ios plugin.
publish_to: none

environment:
sdk: ">=2.18.0 <4.0.0"
flutter: ">=3.3.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

dependencies:
flutter:
Expand Down
4 changes: 2 additions & 2 deletions packages/local_auth/local_auth_ios/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 1.1.3

environment:
sdk: ">=2.18.0 <4.0.0"
flutter: ">=3.3.0"
sdk: ">=3.0.0 <4.0.0"
flutter: ">=3.10.0"

flutter:
plugin:
Expand Down
3 changes: 2 additions & 1 deletion packages/local_auth/local_auth_windows/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT

* Updates minimum supported SDK version to Flutter 3.3/Dart 2.18.
* Fixes stale ignore: prefer_const_constructors.
* Updates minimum supported SDK version to Flutter 3.10/Dart 3.0.

## 1.0.8

Expand Down
12 changes: 4 additions & 8 deletions packages/local_auth/local_auth_windows/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,9 @@ class _MyAppState extends State<MyApp> {
if (_isAuthenticating)
ElevatedButton(
onPressed: _cancelAuthentication,
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
child: Row(
child: const Row(
mainAxisSize: MainAxisSize.min,
children: const <Widget>[
children: <Widget>[
Text('Cancel Authentication'),
Icon(Icons.cancel),
],
Expand All @@ -165,11 +163,9 @@ class _MyAppState extends State<MyApp> {
children: <Widget>[
ElevatedButton(
onPressed: _authenticate,
// TODO(goderbauer): Make this const when this package requires Flutter 3.8 or later.
// ignore: prefer_const_constructors
child: Row(
child: const Row(
mainAxisSize: MainAxisSize.min,
children: const <Widget>[
children: <Widget>[
Text('Authenticate'),
Icon(Icons.perm_device_information),
],
Expand Down
Loading