Skip to content

Fix stale ignore: prefer_const_constructors from flutter/packages #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 8, 2023
Merged

Fix stale ignore: prefer_const_constructors from flutter/packages #4154

merged 12 commits into from
Jun 8, 2023

Conversation

ayinloya
Copy link
Contributor

@ayinloya ayinloya commented Jun 6, 2023 •
edited by stuartmorgan-g
Loading

Update the flutter version in affected packages to 3.10.0
Fix stale ignore: prefer_const_constructors from flutter/packages

Fixes flutter/flutter#128141

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot removed the p: camera label Jun 7, 2023
@stuartmorgan-g stuartmorgan-g added the override: no versioning needed Override the check requiring version bumps for most changes label Jun 7, 2023
@stuartmorgan-g
Copy link
Contributor

Overriding version check: The changes that are being flagged are:

  • example main.dart files, but having that updated on pub.dev isn't important enough to publish just for that, and
  • upping minimum SDK versions, which we deliberately don't publish for without other changes per the exemption list

stuartmorgan-g
stuartmorgan-g requested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! Just a few minor nits, then it'll be good to land.

@ayinloya ayinloya requested a review from tarrinneal as a code owner June 7, 2023 19:06
@ayinloya ayinloya force-pushed the remove-stale-ignore-prefer-const-constructors branch from 58f5dbe to af9ae24 Compare June 7, 2023 20:09
@github-actions github-actions bot removed the p: pigeon label Jun 7, 2023
ayinloya added 2 commits June 7, 2023 21:49
@ayinloya ayinloya force-pushed the remove-stale-ignore-prefer-const-constructors branch from af9ae24 to 54179b5 Compare June 7, 2023 21:50
stuartmorgan-g
stuartmorgan-g approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023
@auto-submit auto-submit bot merged commit 3e0a170 into flutter:main Jun 8, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
3e0a170 Fix stale ignore: prefer_const_constructors from flutter/pack…
4484ff7 
…ages (flutter/packages#4154)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
Roll Packages from e13b8c4 to afe2f05 (7 revisions) (#128582)
f655843 
flutter/packages@e13b8c4...afe2f05

2023-06-08 stuartmorgan@google.com [image_picker] Add desktop support - platform interface (flutter/packages#4161)
2023-06-08 nils@reichardt.io [go_router] Update link to example for query and path parameters (flutter/packages#3994)
2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.0 to 1.8.21 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3839)
2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter/packages#3768)
2023-06-08 stuartmorgan@google.com [webview_flutter] Explicitly disable ATS in example apps (flutter/packages#4166)
2023-06-08 engine-flutter-autoroll@skia.org Roll Flutter from 8a5c22e to 6e254a3 (12 revisions) (flutter/packages#4165)
2023-06-08 banasco@gmail.com Fix stale ignore: prefer_const_constructors from flutter/packages (flutter/packages#4154)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

@cbracken cbracken Awaiting requested review from cbracken cbracken is a code owner

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu

@camsim99 camsim99 Awaiting requested review from camsim99

@Hixie Hixie Awaiting requested review from Hixie Hixie is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@tarrinneal tarrinneal Awaiting requested review from tarrinneal

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no versioning needed Override the check requiring version bumps for most changes p: flutter_adaptive_scaffold p: flutter_markdown p: google_maps_flutter p: local_auth p: rfw Remote Flutter Widgets p: url_launcher platform-android platform-ios platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix stale ignore: prefer_const_constructors from flutter/packages
4 participants
@ayinloya @stuartmorgan-g @domesticmouse @gspencergoog