[quick_actions] Fix Android lint issues #3885
Conversation
Removes lint-baseline.xml and fixes all warnings. Part of flutter/flutter#88011
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| List<ShortcutInfo> shortcuts = deserializeShortcuts(serializedShortcuts); | ||
|
|
||
| Executor uiThreadExecutor = new UiThreadExecutor(); | ||
| ThreadPoolExecutor executor = | ||
| new ThreadPoolExecutor( | ||
| 0, 1, 1, TimeUnit.SECONDS, new LinkedBlockingQueue<Runnable>()); | ||
| new ThreadPoolExecutor(0, 1, 1, TimeUnit.SECONDS, new LinkedBlockingQueue<>()); |
There was a problem hiding this comment.
What's the warning with Runnable? Just curious
There was a problem hiding this comment.
I'm pretty sure this is one of the AS-specific lints rather than something that shows up in our tooling checks, but I cleaned it up since it's trivial and reduces warning noise in Android Studio. The message is just something along the lines of LinkedBlockingQueue<Runnable> could be LinkedBlockingQueue<>. It's because specifying the generic isn't necessary when it can be clearly inferred from context (like here, where the method parameter requires a ...<Runnable>).
Removing the baseline is the test here. |
stuartmorgan-g
added
autosubmit
flutter/packages@407b7da...6bd59cd 2023-05-04 41930132+hellohuanlin@users.noreply.github.com [pigeon][reland]enable treat warnings as errors for swift code in unit test (flutter/packages#3901) 2023-05-04 stuartmorgan@google.com [video_player] Fix Android lints (flutter/packages#3886) 2023-05-04 stuartmorgan@google.com [quick_actions] Fix Android lint issues (flutter/packages#3885) 2023-05-03 andrewjohncoutts@gmail.com [camera_platform_interface] [camera] [camera_android] Add NV21 as an image stream format (flutter/packages#3277) 2023-05-03 stuartmorgan@google.com Revert "[pigeon]enable treat warning as errors for swift code in unit test" (flutter/packages#3898) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Removes lint-baseline.xml and fixes all warnings. Part of flutter/flutter#88011
Removes lint-baseline.xml and fixes all warnings.
Part of flutter/flutter#88011
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).