[pigeon][reland]enable treat warnings as errors for swift code in unit test #3901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
changed the title
hellohuanlin
changed the title
hellohuanlin
force-pushed
the
pigeon_swift_reland_treat_warning_as_error
branch
from
4f7a76c to
cdfe5f6
Compare
jmagman
approved these changes
May 4, 2023
hellohuanlin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 4, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 4, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 4, 2023
flutter/packages@407b7da...6bd59cd 2023-05-04 41930132+hellohuanlin@users.noreply.github.com [pigeon][reland]enable treat warnings as errors for swift code in unit test (flutter/packages#3901) 2023-05-04 stuartmorgan@google.com [video_player] Fix Android lints (flutter/packages#3886) 2023-05-04 stuartmorgan@google.com [quick_actions] Fix Android lint issues (flutter/packages#3885) 2023-05-03 andrewjohncoutts@gmail.com [camera_platform_interface] [camera] [camera_android] Add NV21 as an image stream format (flutter/packages#3277) 2023-05-03 stuartmorgan@google.com Revert "[pigeon]enable treat warning as errors for swift code in unit test" (flutter/packages#3898) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
This was referenced Jul 7, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…t test (flutter#3901) `as [Any?]` here is actually not a "cast", but a "type annotation". An equivalent fix can be: ``` let arg: [Any?] = [nil] let inputEncoded = binaryMessenger.codec.encode(arg) ``` Fixes ``` heterogeneous collection literal could only be inferred to '[Any?]'; add explicit type annotation if this is intentional ``` Which was introduced in flutter#3889 and later got reverted. See flutter/flutter#126006 for more details about some interesting research on this warning. *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#126006 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as [Any?]here is actually not a "cast", but a "type annotation". An equivalent fix can be:Fixes
Which was introduced in #3889 and later got reverted.
See flutter/flutter#126006 for more details about some interesting research on this warning.
List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#126006
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.