Skip to content

[video_player] add missing_enum_constant_in_switch #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2023
Merged

[video_player] add missing_enum_constant_in_switch #3435

merged 1 commit into from
Mar 10, 2023

Conversation

maRci002
Copy link
Contributor

This PR is part of #3361

This is why this part is created: #3361 (comment)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@maRci002 maRci002 mentioned this pull request Mar 10, 2023
Merged
11 tasks
stuartmorgan-g
stuartmorgan-g approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Mar 10, 2023
@stuartmorgan-g
Copy link
Contributor

Overriding version and changelog: // ignores are dev-only.

@stuartmorgan-g
Copy link
Contributor

Sorry, wrong button :(

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes and removed override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Mar 10, 2023
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2023
@auto-submit auto-submit bot merged commit fbcd57e into flutter:main Mar 10, 2023
jackyshan added a commit to jackyshan/packages that referenced this pull request Mar 11, 2023
@jackyshan
Merge remote-tracking branch 'origin/main' into not-gen-skip-hostapi
e2e876c 
* origin/main:
  [image_picker] Remove MethodCall from most Android code (flutter#3438)
  add missing_enum_constant_in_switch (flutter#3435)
  [go_router_builder] Generate the enum map for enum used in iterable (flutter#3415)
  [pigeon] finish kotlin and swift safe cast removal (flutter#3360)
  [tool] Include examples when pathifying deps (flutter#3393)
  url change for platform interface (flutter#3323)

# Conflicts:
#	packages/pigeon/CHANGELOG.md
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
fbcd57e add missing_enum_constant_in_switch (flutter/packages#3435)
72f2315
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
fbcd57e add missing_enum_constant_in_switch (flutter/packages#3435)
15e0079
@maRci002 maRci002 mentioned this pull request Mar 16, 2023
Merged
11 tasks
@reidbaker reidbaker mentioned this pull request Mar 20, 2023
Merged
10 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@maRci002 @nploi
add missing_enum_constant_in_switch (flutter#3435)
fa2f334 
[video_player] add missing_enum_constant_in_switch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin hellohuanlin is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: video_player platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maRci002 @stuartmorgan-g @tarrinneal