Skip to content

[go_router_builder] Generate the enum map for enum used in iterable #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 10, 2023
Merged

[go_router_builder] Generate the enum map for enum used in iterable #3415

merged 4 commits into from
Mar 10, 2023

Conversation

ValentinVignal
Copy link
Contributor

Fixes flutter/flutter#122181

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ValentinVignal ValentinVignal requested a review from chunhtai as a code owner March 8, 2023 13:42
@chunhtai chunhtai requested review from GemmaJAy and hannah-hyj and removed request for GemmaJAy and chunhtai March 8, 2023 17:03
hannah-hyj
hannah-hyj approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chunhtai
chunhtai approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a route to all type example and add a test for it?

@ValentinVignal
Copy link
Contributor Author

LGTM, can you add a route to all type example and add a test for it?

@chunhtai Added in test: Add enum only used in iterable to all types examples

@chunhtai chunhtai self-requested a review March 10, 2023 16:45
chunhtai
chunhtai approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 10, 2023
@auto-submit auto-submit bot merged commit b92b29f into flutter:main Mar 10, 2023
jackyshan added a commit to jackyshan/packages that referenced this pull request Mar 11, 2023
@jackyshan
Merge remote-tracking branch 'origin/main' into not-gen-skip-hostapi
e2e876c 
* origin/main:
  [image_picker] Remove MethodCall from most Android code (flutter#3438)
  add missing_enum_constant_in_switch (flutter#3435)
  [go_router_builder] Generate the enum map for enum used in iterable (flutter#3415)
  [pigeon] finish kotlin and swift safe cast removal (flutter#3360)
  [tool] Include examples when pathifying deps (flutter#3393)
  url change for platform interface (flutter#3323)

# Conflicts:
#	packages/pigeon/CHANGELOG.md
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
b92b29f [go_router_builder] Generate the enum map for enum used in it…
ff1c0ad 
…erable (flutter/packages#3415)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 13, 2023
@engine-flutter-autoroll
b92b29f [go_router_builder] Generate the enum map for enum used in it…
74c1318 
…erable (flutter/packages#3415)
@reidbaker reidbaker mentioned this pull request Mar 20, 2023
Merged
10 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@ValentinVignal @nploi
[go_router_builder] Generate the enum map for enum used in iterable (f…
2ba5f12 
…lutter#3415)

[go_router_builder] Generate the enum map for enum used in iterable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: go_router_builder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[go_router_builder] Enum map is not generated for iterables
3 participants
@ValentinVignal @chunhtai @hannah-hyj