[animations] Introduce layoutBuilder parameter to PageTransitionSwitcher #170

federunco · 2020-06-15T15:09:08Z

Fixes flutter/flutter#54585 by introducing layoutBuilder, which allows PageTransitionSwitcher to lay out its children in a custom manner.

googlebot · 2020-06-15T15:09:14Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

federunco · 2020-06-15T15:09:59Z

@googlebot I signed it!

googlebot · 2020-06-15T15:10:03Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

shihaohong · 2020-06-16T09:41:17Z

@goderbauer This would solve the problem in flutter/flutter#54585 if Alignment.topLeft was passed into Stack.

I'm wondering if this should just be Alignment.topLeft by default, but also warn developers about having the passed child widgets be the same size or provide guidance on how to do so through documentation.

goderbauer

This PR is also missing tests. Can you please add some?

goderbauer · 2020-06-16T17:04:13Z

packages/animations/lib/src/page_transition_switcher.dart

-  Animation<double> primaryAnimation,
-  Animation<double> secondaryAnimation,
-);
+    Widget child,


revert these formatting changes.

goderbauer · 2020-06-16T17:04:29Z

packages/animations/lib/src/page_transition_switcher.dart

@@ -149,6 +148,7 @@ class PageTransitionSwitcher extends StatefulWidget {
    this.duration = const Duration(milliseconds: 300),
    this.reverse = false,
    @required this.transitionBuilder,
+    this.alignment = Alignment.center,


assert that alignment is not null and mention that in the doc above.

goderbauer · 2020-06-16T17:04:53Z

packages/animations/lib/src/page_transition_switcher.dart

@@ -203,6 +203,14 @@ class PageTransitionSwitcher extends StatefulWidget {
  /// The child provided to the transitionBuilder may be null.
  final PageTransitionSwitcherTransitionBuilder transitionBuilder;

+  /// The alignment of [child] when its animated


nit: its -> it's

goderbauer · 2020-06-16T17:05:14Z

packages/animations/lib/src/page_transition_switcher.dart

+  /// The given alignment is applied during the animation of the child, when
+  /// the animation is finished, the original alignment is applied to the child.
+  ///
+  /// Defaults to Alignment.center


Suggested change

/// Defaults to Alignment.center

/// Defaults to [Alignment.center].

goderbauer · 2020-06-16T17:05:30Z

packages/animations/lib/src/page_transition_switcher.dart

+  /// The alignment of [child] when its animated
+  ///
+  /// The given alignment is applied during the animation of the child, when
+  /// the animation is finished, the original alignment is applied to the child.


It's not clear what "the original alignment" is.

goderbauer · 2020-06-16T17:05:50Z

packages/animations/lib/src/page_transition_switcher.dart

@@ -310,8 +318,8 @@ class _PageTransitionSwitcherState extends State<PageTransitionSwitcher>
      secondaryController,
    );
    assert(
-      transition != null,
-      'PageTransitionSwitcher.builder must not return null.',
+    transition != null,


revert formatting change

goderbauer · 2020-06-16T17:05:59Z

packages/animations/lib/src/page_transition_switcher.dart

@@ -352,8 +360,8 @@ class _PageTransitionSwitcherState extends State<PageTransitionSwitcher>
      entry.secondaryController,
    );
    assert(
-      transition != null,
-      'PageTransitionSwitcher.builder must not return null.',
+    transition != null,


revert formatting change

goderbauer · 2020-06-16T17:21:18Z

I'm wondering if this should just be Alignment.topLeft by default, but also warn developers about having the passed child widgets be the same size or provide guidance on how to do so through documentation.

AlignmentDirectional.topStart may have been an alternative choice for the default.

This widget was heavily inspired by the AnimatedSwitcher (https://master-api.flutter.dev/flutter/widgets/AnimatedSwitcher-class.html), which also uses center as the default. That widget solves this problem by allowing the user to completely configure the layout via a provided layoutBuilder (https://master-api.flutter.dev/flutter/widgets/AnimatedSwitcher/layoutBuilder.html). We should probably do the same for this widget as well to give users maximum flexibility in case they want to change other aspects of the Stack.

federunco · 2020-06-16T19:00:28Z

Should I implement a layoutBuilder?

shihaohong · 2020-06-17T03:08:19Z

@federunco that seems like a more flexible way to approach this problem, since it allows devs to have a more fine-tuned control of the layout of the outgoing/incoming widgets.

goderbauer · 2020-06-17T21:52:37Z

fly-by comment: looks like the analyzer is unhappy. It may require the submission of #173 to fix that.

shihaohong

Some comments about the documentation. It also needs a test or two to ensure that the default layout is preserved, as well as another test to ensure that a modified layoutBuilder is properly used.

shihaohong · 2020-06-18T02:11:31Z

packages/animations/lib/src/page_transition_switcher.dart

@@ -142,17 +153,19 @@ typedef PageTransitionSwitcherTransitionBuilder = Widget Function(
 class PageTransitionSwitcher extends StatefulWidget {
  /// Creates a [PageTransitionSwitcher].
  ///
-  /// The [duration], [reverse], and [transitionBuilder] parameters
+  /// The [duration], [reverse], [transitionBuilder] and [alignment] parameters


Since alignment had been removed:

Suggested change

/// The [duration], [reverse], [transitionBuilder] and [alignment] parameters

/// The [duration], [reverse], and [transitionBuilder] parameters

shihaohong · 2020-06-18T02:14:43Z

packages/animations/lib/src/page_transition_switcher.dart

+  /// the [child] that's transitioning in, with a widget that lays all of them
+  /// out. This is called every time this widget is built. The function must not
+  /// return null.
+  ///


We should add some sample code here for one or two use cases for modifying the layoutBuilder here. Otherwise, developers may not know how to go to this parameter to resolve their problem.

Also, since this property's purpose might be less intuitive from just reading its name, it might be helpful to put a pointer to here from the constructor or class API docs as well. Something like: "If the layout of the transitioning child widgets are not what you are looking for, see layoutBuilder for suggestions on how to configure the layout of the incoming and outgoing child widgets."

shihaohong · 2020-06-25T23:41:51Z

Hey @federunco, any progress on this PR?

federunco · 2020-06-27T16:20:35Z

I should update the PR next wednesday, i'm quite busy at the moment

shihaohong · 2020-06-29T03:04:26Z

Sounds good, thanks for the update.

shihaohong · 2020-07-06T02:33:37Z

Seems like the formatter is still unhappy with one of the dart files.

shihaohong

The implementation itself looks good, there are two main types of comments:

Some clarifications for the API just so that our users aren't confused by how to use the new layoutBuilder parameter and the terminology surrounding it.
Seeing if there's some way to keep the instantiating ChildEntry private to the library, since we do not want our users getting the wrong idea on how to use it and trying to instantiate ChildEntry in their applications.

shihaohong · 2020-07-10T07:23:14Z

packages/animations/lib/src/page_transition_switcher.dart

+/// Internal representation of a child that, now or in the past, was set on the
+/// PageTransitionSwitcher.child field, but is now in the process of
+/// transitioning.


Since ChildEntry should not really be used as a "public API", but is necessary because it needs to be exposed as an argument for layoutBuilder, I think at the very least we should document how this is used for and that users of the animations package shouldn't be using this class unless they were using it together with PageTransitionSwitcher.layoutBuilder. This is my attempt to clarify this a little bit:

Suggested change

/// Internal representation of a child that, now or in the past, was set on the

/// PageTransitionSwitcher.child field, but is now in the process of

/// transitioning.

/// An internal representation of a child widget subtree that, now or in the past,

/// was set on the PageTransitionSwitcher.child field and is now in the process of

/// transitioning.

///

/// This class should not be used outside of the context of

/// [PageTransitionSwitcher.layoutBuilder], which uses this class in a callback to

/// customize the layout of the transitioning widgets.

///

/// For more information, please see the documentation of

/// [PageTransitionSwitcher.layoutBuilder].

shihaohong · 2020-07-10T07:30:46Z

packages/animations/lib/src/page_transition_switcher.dart

+  ///
+  /// The [primaryController], [secondaryController], [transition] and
+  /// [widgetChild] parameters must not be null.
+  ChildEntry({


cc/ @goderbauer I've never tried this before, but would it be possible to make this constructor private while keeping the class itself public? That way we don't get users that attempt to create a ChildEntry outside of the context of the PageTransitionSwitcher widget, but they can still use it in the callback for layoutBuilder:

Suggested change

ChildEntry({

ChildEntry._({

Yes, you can do that :)

shihaohong · 2020-07-13T08:57:46Z

packages/animations/lib/src/page_transition_switcher.dart

  Widget widgetChild;

+  /// Animation disposal method


Use verbiage similar to other api documentation for dispose

Suggested change

/// Animation disposal method

/// Release the resources used by this object.

///

/// The object is no longer usable after this method is called.

packages/animations/lib/src/page_transition_switcher.dart

shihaohong · 2020-07-13T09:04:29Z

packages/animations/lib/src/page_transition_switcher.dart

+/// PageTransitionSwitcher uses the property [layoutBuilder] to lay out all
+/// active entries.
+/// If the layout of the transitioning child widgets are not what you are looking
+/// for, see [PageTransitionSwitcher.layoutBuilder] for suggestions on how to
+/// configure the layout of the incoming and outgoing child widgets


Here are some grammatical suggestions. I also removed the usage of "active entries" since users will be more familiar with referring to the new and old child widgets based on prior documentation.

Suggested change

/// PageTransitionSwitcher uses the property [layoutBuilder] to lay out all

/// active entries.

/// If the layout of the transitioning child widgets are not what you are looking

/// for, see [PageTransitionSwitcher.layoutBuilder] for suggestions on how to

/// configure the layout of the incoming and outgoing child widgets

/// PageTransitionSwitcher uses the [layoutBuilder] property to lay out the

/// old and new child widgets. By default, [defaultLayoutBuilder] is used.

/// See the documentation for [layoutBuilder] for suggestions on how to

/// configure the layout of the incoming and outgoing child widgets if

/// [defaultLayoutBuilder] is not your desired layout.

shihaohong · 2020-07-13T09:05:59Z

packages/animations/lib/src/page_transition_switcher.dart

+  ///    how a layout builder should function.
+  ///
+  /// The following example shows a [layoutBuilder] that places the new child inside
+  /// a [Column], that sizes its height depending on the heights of active entries.


nit:

Suggested change

/// a [Column], that sizes its height depending on the heights of active entries.

/// a [Column] that sizes its height depending on the heights of active entries.

shihaohong · 2020-07-13T09:07:20Z

packages/animations/lib/src/page_transition_switcher.dart

+///
+/// The builder should return a widget which contains the given children, laid
+/// out as desired. It must not return null. The builder should be able to
+/// handle an empty list of `_activeEntries`.


We should define "active entries" here, since users might not get what these refer to. The only reference they have without peeking into the implementation is the concept of an "old" and "new" child widget, so this concept will need to be clarified.

shihaohong · 2020-07-13T09:08:19Z

packages/animations/lib/src/page_transition_switcher.dart

+  /// largest of the child or a previous child. The children are centered on
+  /// each other.
+  ///
+  /// This is an [PageTransitionSwitcherTransitionBuilder] function.


Suggested change

/// This is an [PageTransitionSwitcherTransitionBuilder] function.

/// See [PageTransitionSwitcherTransitionBuilder] for more information on the function signature.

shihaohong · 2020-07-13T09:08:56Z

packages/animations/lib/src/page_transition_switcher.dart

+  ///
+  final PageTransitionSwitcherLayoutBuilder layoutBuilder;
+
+  /// The layout builder used as the default value of [layoutBuilder].


Suggested change

/// The layout builder used as the default value of [layoutBuilder].

/// The default layout builder for [PageTransitionSwitcher].

shihaohong · 2020-07-13T09:11:26Z

packages/animations/lib/src/page_transition_switcher.dart

+  /// The new child is placed in a [Stack] that sizes itself to match the
+  /// largest of the child or a previous child. The children are centered on
+  /// each other.


Also, doesn't the [Stack] size itself to match the largest child, not the previous child?

Suggested change

/// The new child is placed in a [Stack] that sizes itself to match the

/// largest of the child or a previous child. The children are centered on

/// each other.

/// This function is the default way for how the new and old child widgets are placed

/// during the transition between the two widgets. The new child is placed in a

/// [Stack] that sizes itself to match the largest of the child or a previous child.

/// The children are centered on each other.

federunco · 2020-07-22T12:20:25Z

I've pushed all the suggested changes, how about making ChildEntry constructor private, any news?

shihaohong · 2020-07-22T16:44:23Z

@federunco I think we should make the constructor private. That way, nobody can accidentally abuse the ChildEntry class.

shihaohong

LGTM modulo a doc comment nit.

@goderbauer could you take a look to make sure this looks good?

shihaohong · 2020-07-29T09:39:24Z

packages/animations/lib/src/page_transition_switcher.dart

-// to expose to the public API (like the controllers).
-class _ChildEntry {
-  _ChildEntry({
+// An internal representation of a child widget subtree that, now or in the past,


Suggested change

// An internal representation of a child widget subtree that, now or in the past,

/// An internal representation of a child widget subtree that, now or in the past,

goderbauer · 2020-08-05T21:55:55Z

Added to my review queue. Sorry for the delay.

goderbauer · 2020-08-07T16:48:51Z

packages/animations/lib/src/page_transition_switcher.dart

-class _ChildEntry {
-  _ChildEntry({
+// An internal representation of a child widget subtree that, now or in the past,
+/// was set on the PageTransitionSwitcher.child field and is now in the process of


Suggested change

/// was set on the PageTransitionSwitcher.child field and is now in the process of

/// was set on the [PageTransitionSwitcher.child] field and is now in the process of

goderbauer · 2020-08-07T16:50:54Z

packages/animations/lib/src/page_transition_switcher.dart

+///
+/// The builder should return a widget which contains the given children, laid
+/// out as desired. It must not return null. The builder should be able to
+/// handle an empty list of `_activeEntries`.


A comment on a public member should nor reference a private member.

goderbauer · 2020-08-07T16:51:14Z

packages/animations/lib/src/page_transition_switcher.dart

+/// out as desired. It must not return null. The builder should be able to
+/// handle an empty list of `_activeEntries`.
+typedef PageTransitionSwitcherLayoutBuilder = Widget Function(
+  List<ChildEntry> _activeEntries,


_activeEntries -> activeEntries

Or why not just entries?

goderbauer · 2020-08-07T16:52:19Z

packages/animations/lib/src/page_transition_switcher.dart

+  /// out. This is called every time this widget is built. The function must not
+  /// return null.
+  ///
+  /// The default is [PageTransitionSwitcherLayoutBuilder] used is


remove the first "is".

goderbauer · 2020-08-07T16:53:00Z

packages/animations/lib/src/page_transition_switcher.dart

+  /// See also:
+  ///
+  ///  * [PageTransitionSwitcherLayoutBuilder] for more information about
+  ///    how a layout builder should function.


The see also section should always come last.

packages/animations/lib/src/page_transition_switcher.dart

goderbauer · 2020-08-07T16:54:31Z

packages/animations/lib/src/page_transition_switcher.dart

+  /// The following example shows a [layoutBuilder] that places the new child inside
+  /// a [Column] that sizes its height depending on the heights of active entries.


This seems a little confusing. The layoutBuilder puts all children in a column, not just the new one.

goderbauer · 2020-08-07T16:55:08Z

packages/animations/lib/src/page_transition_switcher.dart

+  /// ```dart
+  /// layoutBuilder: (
+  ///   List<ChildEntry> activeEntries,
+  /// ) => Column(


What effect is this example trying to achieve? It seems odd to just place them all in a column?

goderbauer · 2020-08-07T16:55:31Z

packages/animations/lib/src/page_transition_switcher.dart

+  /// during the transition between the two widgets. The new child is placed in a
+  /// [Stack] that sizes itself to match the largest of the child or a previous child.
+  /// The children are centered on each other.


not just the new child, all children are placed in a stack.

goderbauer · 2020-08-07T16:57:55Z

packages/animations/lib/src/page_transition_switcher.dart

+  ///
+  /// The [primaryController], [secondaryController], [transition] and
+  /// [widgetChild] parameters must not be null.
+  ChildEntry({


Yes, you can do that :)

goderbauer · 2020-08-07T17:02:01Z

packages/animations/lib/src/page_transition_switcher.dart

+/// out as desired. It must not return null. The builder should be able to
+/// handle an empty list of `_activeEntries`.
+typedef PageTransitionSwitcherLayoutBuilder = Widget Function(
+  List<ChildEntry> _activeEntries,


Why do we hand the full ChildEntry to the layoutBuilder? It seems that handing them just the transition Widgets from the ChildEntries would be enough. The layout builder shouldn't have access to the animation controllers in ChildEntry. Those shouldn't be messed with.

Similarly to AnimatedSwitcher's layoutBuilder it probably also makes sense to hand over the currentEntry and all other entries in separate arguments.

In other words, _ChildEntry should stay private.

goderbauer · 2020-08-07T17:03:59Z

packages/animations/lib/src/page_transition_switcher.dart

+/// out as desired. It must not return null. The builder should be able to
+/// handle an empty list of `_activeEntries`.
+typedef PageTransitionSwitcherLayoutBuilder = Widget Function(
+  List<ChildEntry> _activeEntries,


In other words, _ChildEntry should stay private.

federunco · 2020-08-15T14:12:22Z

I made all the suggested changes, I used most of the AnimatedSwitcher code (just deleted some of the assertions that didn't make sense when the switcher was set in reverse and tweaked the code a bit) but I didn't test it on a real device, all the unit test passed btw.

goderbauer · 2020-08-17T17:35:33Z

packages/animations/lib/src/page_transition_switcher.dart

@@ -6,11 +6,14 @@ import 'package:flutter/animation.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/widgets.dart';

-// Internal representation of a child that, now or in the past, was set on the
-// PageTransitionSwitcher.child field, but is now in the process of
-// transitioning. The internal representation includes fields that we don't want


Leave the comment about how we don't want to expose some of these fields?

goderbauer · 2020-08-17T17:37:07Z

packages/animations/lib/src/page_transition_switcher.dart

 class PageTransitionSwitcher extends StatefulWidget {
  /// Creates a [PageTransitionSwitcher].
  ///
-  /// The [duration], [reverse], and [transitionBuilder] parameters
+  /// The [duration], [reverse] and [transitionBuilder] parameters


nit: leave this comma as is, https://en.wikipedia.org/wiki/Serial_comma

goderbauer · 2020-08-17T17:39:25Z

packages/animations/lib/src/page_transition_switcher.dart

+  /// See [PageTransitionSwitcherTransitionBuilder] for more information on the function
+  /// signature.
+  static Widget defaultLayoutBuilder(
+      Widget currentChild, List<Widget> previousChildren, bool reverse) {


nit:

Suggested change

Widget currentChild, List<Widget> previousChildren, bool reverse) {

Widget currentChild, List<Widget> previousChildren, bool reverse,) {

... and then format with flutter format

goderbauer · 2020-08-17T17:40:42Z

packages/animations/test/page_transition_switcher_test.dart

+      /*
+      return Column(
+        children: activeEntries
+            .map<Widget>((ChildEntry entry) => entry.transition)
+            .toList(),
+      );*/


Why is this commented out?

goderbauer · 2020-08-17T17:44:41Z

packages/animations/lib/src/page_transition_switcher.dart

@@ -226,7 +314,9 @@ class _PageTransitionSwitcherState extends State<PageTransitionSwitcher>
    // If the transition builder changed, then update all of the old
    // transitions.
    if (widget.transitionBuilder != oldWidget.transitionBuilder) {
-      _activeEntries.forEach(_updateTransitionForEntry);
+      _outgoingEntries.forEach(_updateTransitionForEntry);
+      if (_currentEntry != null) _updateTransitionForEntry(_currentEntry);


use { } around the body of the if and put it on a separate line.

goderbauer · 2020-08-17T17:45:39Z

packages/animations/lib/src/page_transition_switcher.dart

-    if (widget.child == null) {
-      return;
-    }
+    if (widget.child == null) return;


leave this as-as

goderbauer · 2020-08-17T17:46:53Z

packages/animations/lib/src/page_transition_switcher.dart

@@ -363,19 +438,25 @@ class _PageTransitionSwitcherState extends State<PageTransitionSwitcher>

  @override
  void dispose() {
-    for (_ChildEntry entry in _activeEntries) {
+    if (_currentEntry != null) _currentEntry.dispose();


use { } around body and put body on new line

goderbauer · 2020-08-17T17:48:03Z

packages/animations/lib/src/page_transition_switcher.dart

      entry.dispose();
    }
    super.dispose();
  }

+  void _markChildWidgetCacheAsDirty() => _outgoingWidgets = null;


Suggested change

void _markChildWidgetCacheAsDirty() => _outgoingWidgets = null;

void _markChildWidgetCacheAsDirty() {

_outgoingWidgets = null;

}

goderbauer · 2020-08-17T17:51:48Z

packages/animations/lib/src/page_transition_switcher.dart

      if (widget.reverse) {
        _currentEntry.primaryController.reverse();
      } else {
        _currentEntry.secondaryController.forward();
      }
+      _outgoingEntries.add(_currentEntry);


This will not work: It will cause the order of widgets to change unexpectedly if _currentEntry was previously shown below all _outgoingEntries instead of on top of it.

Maybe the layout builder for this widget should just get a List of widgets without knowledge of the current entry, to avoid this problem?

So the old activeEntries list, right?

goderbauer · 2020-08-17T17:54:45Z

Also: the analyzer check is unhappy. You may have to rebase this PR to the latest master.

Workaround for flutter/flutter#54585

shihaohong · 2020-08-19T02:46:58Z

It seems to still be failing the analyzer check. Make sure to run flutter analyze on the animations package repo and correct any warnings/errors to make sure that everything looks good.

shihaohong

Still LGTM, with a nit on the sample code

packages/animations/lib/src/page_transition_switcher.dart

Co-authored-by: Shi-Hao Hong <shihaohong@google.com>

goderbauer

Generally, this looks good now after the two comments are resolved.

goderbauer · 2020-08-27T20:19:22Z

packages/animations/lib/src/page_transition_switcher.dart

+/// This class should not be used outside of the context of
+/// [PageTransitionSwitcher.layoutBuilder], which uses this class in a callback to
+/// customize the layout of the transitioning widgets.
+///
+/// For more information, please see the documentation of
+/// [PageTransitionSwitcher.layoutBuilder].


This comment seems outdated. It's not used as part of the layoutBuilder anymore?

goderbauer · 2020-08-27T20:21:39Z

packages/animations/lib/src/page_transition_switcher.dart

+  /// [defaultLayoutBuilder].
+  ///
+  /// The following example shows a [layoutBuilder] that places all entries inside
+  /// a [Column] that sizes its height depending on the heights of active entries.


Ideally, examples should show good practices. I can't think of any good use cases where putting the children in a column is a good idea. Maybe show an example where a Stack with a different alignment is used (e.g. topleft.)

shihaohong · 2020-09-03T23:04:48Z

The latest changes look like they address @goderbauer 's concerns and he's on vacation, so I'll merge the PR for now. If he has any issues with it, we can always just revert it or fix forward. Thank you so much for working through this PR!

shihaohong changed the title ~~Make Stack alignment a property~~ [animations] Allow Stack alignment to be adjusted in PageTransitionSwitcher Jun 16, 2020

goderbauer reviewed Jun 16, 2020

View reviewed changes

shihaohong reviewed Jun 18, 2020

View reviewed changes

shihaohong changed the title ~~[animations] Allow Stack alignment to be adjusted in PageTransitionSwitcher~~ [animations] Introduce layoutBuilder parameter to PageTransitionSwitcher Jun 18, 2020

shihaohong mentioned this pull request Jun 18, 2020

[Animations] SharedAxisTransition children have improper layout during transition when children are of different size flutter/flutter#54585

Closed

shihaohong self-assigned this Jul 8, 2020

shihaohong reviewed Jul 13, 2020

View reviewed changes

shihaohong approved these changes Jul 29, 2020

View reviewed changes

goderbauer reviewed Aug 7, 2020

View reviewed changes

goderbauer requested changes Aug 7, 2020

View reviewed changes

goderbauer reviewed Aug 17, 2020

View reviewed changes

Make Stack alignment a property

b7e078c

Workaround for flutter/flutter#54585

federunco added 12 commits August 17, 2020 23:39

Implemented layoutBuilder in PageTransitionSwitcher

ab7ee43

Fix for flutter#173

926c402

Added tests

b4b70fe

Exposed ChildEntry

17813e1

Test fixes

5abaf0f

Update page_transition_switcher.dart

98838e6

Update page_transition_switcher.dart

6a409f0

Update page_transition_switcher.dart

673e563

Update page_transition_switcher.dart

d45e127

Update page_transition_switcher.dart

f33d233

Made ChildEntry constructor private

af582da

Made ChildEntry class private

45ac727

federunco force-pushed the patch-1 branch from 81f3e1a to 45ac727 Compare August 17, 2020 21:40

federunco added 2 commits August 23, 2020 01:26

Implemented "entries" list in LayoutBuilder

6ed9f0d

Format code

4073a15

shihaohong approved these changes Aug 24, 2020

View reviewed changes

packages/animations/lib/src/page_transition_switcher.dart Outdated Show resolved Hide resolved

Update packages/animations/lib/src/page_transition_switcher.dart

c5a5794

Co-authored-by: Shi-Hao Hong <shihaohong@google.com>

goderbauer reviewed Aug 27, 2020

View reviewed changes

Updated documentation

f3d766f

shihaohong merged commit bbc94e1 into flutter:master Sep 3, 2020

stuartmorgan pushed a commit to stuartmorgan/packages that referenced this pull request Apr 30, 2021

Fix baseline in lists (flutter#170)

80b982a

	/// Defaults to Alignment.center
	/// Defaults to [Alignment.center].

	/// The [duration], [reverse], [transitionBuilder] and [alignment] parameters
	/// The [duration], [reverse], and [transitionBuilder] parameters

-  /// Animation disposal method
+  /// Release the resources used by this object.
+  ///
+  /// The object is no longer usable after this method is called.

	/// a [Column], that sizes its height depending on the heights of active entries.
	/// a [Column] that sizes its height depending on the heights of active entries.

	/// This is an [PageTransitionSwitcherTransitionBuilder] function.
	/// See [PageTransitionSwitcherTransitionBuilder] for more information on the function signature.

	/// The layout builder used as the default value of [layoutBuilder].
	/// The default layout builder for [PageTransitionSwitcher].

	// An internal representation of a child widget subtree that, now or in the past,
	/// An internal representation of a child widget subtree that, now or in the past,

	/// was set on the PageTransitionSwitcher.child field and is now in the process of
	/// was set on the [PageTransitionSwitcher.child] field and is now in the process of

		/// The following example shows a [layoutBuilder] that places the new child inside
		/// a [Column] that sizes its height depending on the heights of active entries.

	Widget currentChild, List<Widget> previousChildren, bool reverse) {
	Widget currentChild, List<Widget> previousChildren, bool reverse,) {

[animations] Introduce layoutBuilder parameter to PageTransitionSwitcher #170

[animations] Introduce layoutBuilder parameter to PageTransitionSwitcher #170

Conversation

federunco commented Jun 15, 2020 • edited by shihaohong Loading

googlebot commented Jun 15, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

federunco commented Jun 15, 2020

googlebot commented Jun 15, 2020

shihaohong commented Jun 16, 2020

goderbauer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goderbauer commented Jun 16, 2020

federunco commented Jun 16, 2020

shihaohong commented Jun 17, 2020

goderbauer commented Jun 17, 2020

shihaohong left a comment • edited Loading

Choose a reason for hiding this comment

shihaohong Jun 18, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shihaohong commented Jun 25, 2020

federunco commented Jun 27, 2020

shihaohong commented Jun 29, 2020

shihaohong commented Jul 6, 2020

shihaohong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

federunco commented Jul 22, 2020

shihaohong commented Jul 22, 2020

shihaohong left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goderbauer commented Aug 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

federunco commented Aug 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goderbauer commented Aug 17, 2020

shihaohong commented Aug 19, 2020

shihaohong left a comment

Choose a reason for hiding this comment

goderbauer left a comment

federunco commented Jun 15, 2020 •

edited by shihaohong

Loading

shihaohong left a comment •

edited

Loading

shihaohong Jun 18, 2020 •

edited

Loading