[animations] Handle DualTransitionBuilder name conflict with flutter/flutter #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require animations package to use internal version of DualTransitionBuilder to avoid conflicts with flutter/flutter\'s recently merged copy of DualTransitionBuilder'.
shihaohong
changed the title
goderbauer
approved these changes
Jun 17, 2020
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM when Cirrus is happy.
Member
|
Wanna also bump the version and update the changelog to release this? |
Member
|
Looks like the failure on master will be fixed when this change is submitted. |
Author
|
Merging on red |
federunco
added a commit
to federunco/packages
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require animations package to use internal version of DualTransitionBuilder to avoid conflicts with flutter/flutter's recently merged copy of DualTransitionBuilder: flutter/flutter#58686. This will become an issue for developers using the animations package with versions of Flutter newer than flutter/flutter@fe15d1e
Since it is used internally by the library and not exposed to our users, this should be okay. Once DualTransitionBuilder has made it into the stable version of Flutter, we can remove the animations package's copy of the widget altogether. Filed an issue to track in flutter/flutter#59659