Skip to content

[material_ui] Migrate M3 Menu template to use new gen_defaults #13057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 3 commits into from
Oct 2, 2026
Merged

[material_ui] Migrate M3 Menu template to use new gen_defaults #13057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdcf142
Move template/generated code out of temporarily_excluded directory
QuncCccccc Sep 25, 2026
e81251f
[material_ui] Migrate M3 Menu template to use new gen_defaults
QuncCccccc Sep 25, 2026
64391df
Merge remote-tracking branch 'upstream/main' into menu_m3_defaults_mi…
QuncCccccc Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...y_excluded/generated/menu_defaults.g.dart → ...lib/src/generated/menu_defaults_m3.g.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// Do not edit by hand. The code is generated from data in the Material
// Design token database by the script:
// packages/material_ui/tool/gen_defaults/bin/gen_defaults.dart.
part of '../menu_anchor.dart';

class _MenuBarDefaultsM3 extends MenuStyle {
_MenuBarDefaultsM3(this.context)
: super(
Expand Down
259 changes: 2 additions & 257 deletions packages/material_ui/lib/src/menu_anchor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ import 'text_theme.dart';
import 'theme.dart';
import 'theme_data.dart';

part 'generated/menu_defaults_m3.g.dart';

// Examples can assume:
// bool _throwShotAway = false;
// late BuildContext context;
Expand Down Expand Up @@ -4071,260 +4073,3 @@ bool get _platformSupportsAccelerators {
// platforms.
return !_isCupertino;
}

// BEGIN GENERATED TOKEN PROPERTIES - Menu

// Do not edit by hand. The code between the "BEGIN GENERATED" and
// "END GENERATED" comments are generated from data in the Material
// Design token database by the script:
// dev/tools/gen_defaults/bin/gen_defaults.dart.

// dart format off
class _MenuBarDefaultsM3 extends MenuStyle {
_MenuBarDefaultsM3(this.context)
: super(
elevation: const MaterialStatePropertyAll<double?>(3.0),
shape: const MaterialStatePropertyAll<OutlinedBorder>(_defaultMenuBorder),
alignment: AlignmentDirectional.bottomStart,
);

static const RoundedRectangleBorder _defaultMenuBorder =
RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(4.0)));

final BuildContext context;

late final ColorScheme _colors = Theme.of(context).colorScheme;

@override
WidgetStateProperty<Color?> get backgroundColor {
return MaterialStatePropertyAll<Color?>(_colors.surfaceContainer);
}

@override
WidgetStateProperty<Color?>? get shadowColor {
return MaterialStatePropertyAll<Color?>(_colors.shadow);
}

@override
WidgetStateProperty<Color?>? get surfaceTintColor {
return const MaterialStatePropertyAll<Color?>(Colors.transparent);
}

@override
WidgetStateProperty<EdgeInsetsGeometry?>? get padding {
return const MaterialStatePropertyAll<EdgeInsetsGeometry>(
EdgeInsetsDirectional.symmetric(
horizontal: _kTopLevelMenuHorizontalMinPadding
),
);
}

@override
VisualDensity get visualDensity => Theme.of(context).visualDensity;
}

class _MenuButtonDefaultsM3 extends ButtonStyle {
_MenuButtonDefaultsM3(this.context)
: super(
animationDuration: kThemeChangeDuration,
enableFeedback: true,
alignment: AlignmentDirectional.centerStart,
);

final BuildContext context;

late final ColorScheme _colors = Theme.of(context).colorScheme;
late final TextTheme _textTheme = Theme.of(context).textTheme;

@override
WidgetStateProperty<Color?>? get backgroundColor {
return ButtonStyleButton.allOrNull<Color>(Colors.transparent);
}

// No default shadow color

// No default surface tint color

@override
WidgetStateProperty<double>? get elevation {
return ButtonStyleButton.allOrNull<double>(0.0);
}

@override
WidgetStateProperty<Color?>? get foregroundColor {
return WidgetStateProperty.resolveWith((Set<WidgetState> states) {
if (states.contains(WidgetState.disabled)) {
return _colors.onSurface.withOpacity(0.38);
}
if (states.contains(WidgetState.pressed)) {
return _colors.onSurface;
}
if (states.contains(WidgetState.hovered)) {
return _colors.onSurface;
}
if (states.contains(WidgetState.focused)) {
return _colors.onSurface;
}
return _colors.onSurface;
});
}

@override
WidgetStateProperty<Color?>? get iconColor {
return WidgetStateProperty.resolveWith((Set<WidgetState> states) {
if (states.contains(WidgetState.disabled)) {
return _colors.onSurface.withOpacity(0.38);
}
if (states.contains(WidgetState.pressed)) {
return _colors.onSurfaceVariant;
}
if (states.contains(WidgetState.hovered)) {
return _colors.onSurfaceVariant;
}
if (states.contains(WidgetState.focused)) {
return _colors.onSurfaceVariant;
}
return _colors.onSurfaceVariant;
});
}

// No default fixedSize

@override
WidgetStateProperty<double>? get iconSize {
return const MaterialStatePropertyAll<double>(24.0);
}

@override
WidgetStateProperty<Size>? get maximumSize {
return ButtonStyleButton.allOrNull<Size>(Size.infinite);
}

@override
WidgetStateProperty<Size>? get minimumSize {
return ButtonStyleButton.allOrNull<Size>(const Size(64.0, 48.0));
}

@override
WidgetStateProperty<MouseCursor?>? get mouseCursor => WidgetStateMouseCursor.adaptiveClickable;

@override
WidgetStateProperty<Color?>? get overlayColor {
return WidgetStateProperty.resolveWith(
(Set<WidgetState> states) {
if (states.contains(WidgetState.pressed)) {
return _colors.onSurface.withOpacity(0.1);
}
if (states.contains(WidgetState.hovered)) {
return _colors.onSurface.withOpacity(0.08);
}
if (states.contains(WidgetState.focused)) {
return _colors.onSurface.withOpacity(0.1);
}
return Colors.transparent;
},
);
}

@override
WidgetStateProperty<EdgeInsetsGeometry>? get padding {
return ButtonStyleButton.allOrNull<EdgeInsetsGeometry>(_scaledPadding(context));
}

// No default side

@override
WidgetStateProperty<OutlinedBorder>? get shape {
return ButtonStyleButton.allOrNull<OutlinedBorder>(const RoundedRectangleBorder());
}

@override
InteractiveInkFeatureFactory? get splashFactory => Theme.of(context).splashFactory;

@override
MaterialTapTargetSize? get tapTargetSize => Theme.of(context).materialTapTargetSize;

@override
WidgetStateProperty<TextStyle?> get textStyle {
// TODO(tahatesser): This is taken from https://m3.material.io/components/menus/specs
// Update this when the token is available.
return MaterialStatePropertyAll<TextStyle?>(_textTheme.labelLarge);
}

@override
VisualDensity? get visualDensity => Theme.of(context).visualDensity;

// The horizontal padding number comes from the spec.
EdgeInsetsGeometry _scaledPadding(BuildContext context) {
VisualDensity visualDensity = Theme.of(context).visualDensity;
// When horizontal VisualDensity is greater than zero, set it to zero
// because the [ButtonStyleButton] has already handle the padding based on the density.
// However, the [ButtonStyleButton] doesn't allow the [VisualDensity] adjustment
// to reduce the width of the left/right padding, so we need to handle it here if
// the density is less than zero, such as on desktop platforms.
if (visualDensity.horizontal > 0) {
visualDensity = VisualDensity(vertical: visualDensity.vertical);
}
// Since the threshold paddings used below are empirical values determined
// at a font size of 14.0, 14.0 is used as the base value for scaling the
// padding.
final double fontSize = Theme.of(context).textTheme.labelLarge?.fontSize ?? 14.0;
final double fontSizeRatio = MediaQuery.textScalerOf(context).scale(fontSize) / 14.0;
return ButtonStyleButton.scaledPadding(
EdgeInsets.symmetric(horizontal: math.max(
_kMenuViewPadding,
_kLabelItemDefaultSpacing + visualDensity.baseSizeAdjustment.dx,
)),
EdgeInsets.symmetric(horizontal: math.max(
_kMenuViewPadding,
8 + visualDensity.baseSizeAdjustment.dx,
)),
const EdgeInsets.symmetric(horizontal: _kMenuViewPadding),
fontSizeRatio,
);
}
}

class _MenuDefaultsM3 extends MenuStyle {
_MenuDefaultsM3(this.context)
: super(
elevation: const MaterialStatePropertyAll<double?>(3.0),
shape: const MaterialStatePropertyAll<OutlinedBorder>(_defaultMenuBorder),
alignment: AlignmentDirectional.topEnd,
);

static const RoundedRectangleBorder _defaultMenuBorder =
RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(4.0)));

final BuildContext context;

late final ColorScheme _colors = Theme.of(context).colorScheme;

@override
WidgetStateProperty<Color?> get backgroundColor {
return MaterialStatePropertyAll<Color?>(_colors.surfaceContainer);
}

@override
WidgetStateProperty<Color?>? get surfaceTintColor {
return const MaterialStatePropertyAll<Color?>(Colors.transparent);
}

@override
WidgetStateProperty<Color?>? get shadowColor {
return MaterialStatePropertyAll<Color?>(_colors.shadow);
}

@override
WidgetStateProperty<EdgeInsetsGeometry?>? get padding {
return const MaterialStatePropertyAll<EdgeInsetsGeometry>(
EdgeInsetsDirectional.symmetric(vertical: _kMenuVerticalMinPadding),
);
}

@override
VisualDensity get visualDensity => Theme.of(context).visualDensity;
}
// dart format on

// END GENERATED TOKEN PROPERTIES - Menu
4 changes: 2 additions & 2 deletions packages/material_ui/tool/gen_defaults/bin/gen_defaults.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ import '../templates/icon_button_template.dart';
import '../templates/input_chip_template.dart';
import '../templates/input_decorator_template.dart';
import '../templates/list_tile_template.dart';
import '../templates/menu_template.dart';

// import '../templates/menu_template.dart';
// import '../templates/motion_template.dart';
// import '../templates/navigation_bar_template.dart';
// import '../templates/navigation_drawer_template.dart';
Expand Down Expand Up @@ -98,7 +98,7 @@ Future<void> main(List<String> args) async {
const InputChipTemplateM3().generateFile(verbose: verbose);
const InputDecoratorTemplateM3().generateFile(verbose: verbose);
const ListTileTemplateM3().generateFile(verbose: verbose);
// const MenuTemplateM3().generateFile(verbose: verbose);
const MenuTemplateM3().generateFile(verbose: verbose);
// const MotionTemplateM3().generateFile(verbose: verbose);
// const NavigationBarTemplateM3().generateFile(verbose: verbose);
// const NavigationDrawerTemplateM3().generateFile(verbose: verbose);
Expand Down
Loading
Loading